Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add atomic variable to prevent datarace in FlowController [15292] #2887

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Add atomic variable to prevent datarace in FlowController [15292] #2887

merged 1 commit into from
Jul 28, 2022

Conversation

richiware
Copy link
Member

@richiware richiware commented Jul 28, 2022 •
edited by MiguelCompany
Loading

Description

As title says.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware
Refs #15283. Add atomic to prevent datarace
800ace4 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware changed the title Add atomic variable to prevent datarace in FlowController Add atomic variable to prevent datarace in FlowController [15292] Jul 28, 2022
@MiguelCompany MiguelCompany added this to the v2.8.0 milestone Jul 28, 2022
@MiguelCompany
Copy link
Member

@richiprosima Please test windows

MiguelCompany
MiguelCompany approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany merged commit d4bc909 into master Jul 28, 2022
@MiguelCompany MiguelCompany deleted the bugfix/15283 branch July 28, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@richiware @MiguelCompany