Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get WAN address API in TCPv4 transport descriptors #2877

Merged
merged 3 commits into from
Aug 11, 2022
Merged

Get WAN address API in TCPv4 transport descriptors #2877

merged 3 commits into from
Aug 11, 2022

Conversation

rsanchez15
Copy link
Contributor

@rsanchez15 rsanchez15 commented Jul 26, 2022 •
edited by EduPonz
Loading

Add function to TCPv4TransportDescriptor to get the WAN address.

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • ❌ Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A: Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@rsanchez15 rsanchez15 marked this pull request as draft July 26, 2022 07:00
@rsanchez15 rsanchez15 changed the title Set WAN address API Get WAN address API Jul 26, 2022
@rsanchez15 rsanchez15 changed the title Get WAN address API Get WAN address API in TCPv4 transport descriptors Jul 26, 2022
@rsanchez15 rsanchez15 added this to the v2.8.0 milestone Jul 26, 2022
@rsanchez15 rsanchez15 marked this pull request as ready for review July 26, 2022 12:46
@rsanchez15
Copy link
Contributor Author

@richiprosima Please test this

EduPonz
EduPonz suggested changes Aug 8, 2022
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new API to versions.md. Other than that LGTM with green CI

jparisu
jparisu previously approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@jparisu jparisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsanchez15
Set WAN address API
9c43a40 
Signed-off-by: RaulSanchez <[email protected]>
@rsanchez15
Add test
e20032b 
Signed-off-by: RaulSanchez <[email protected]>
@rsanchez15
Add API extension to versions.md
507013b 
Signed-off-by: RaulSanchez <[email protected]>
@rsanchez15
Copy link
Contributor Author

@richiprosima Please test this

@EduPonz EduPonz merged commit 62fb58b into master Aug 11, 2022
@EduPonz EduPonz deleted the feature/get-wan-addr branch August 11, 2022 05:58
juanlofer-eprosima pushed a commit that referenced this pull request Sep 15, 2022
@rsanchez15 @juanlofer-eprosima
Get WAN address API in TCPv4 transport descriptors (#2877)
a3e4181 
* Set WAN address API

Signed-off-by: RaulSanchez <[email protected]>

* Add test

Signed-off-by: RaulSanchez <[email protected]>

* Add API extension to versions.md

Signed-off-by: RaulSanchez <[email protected]>

Signed-off-by: RaulSanchez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz requested changes

@jparisu jparisu jparisu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rsanchez15 @EduPonz @jparisu