Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBQueue move Push and Pop methods [14537] #2673

Merged
merged 4 commits into from
Jul 1, 2022
Merged

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented May 10, 2022

Description

Implement new methods in DBQueue class so it allows to move elements TO the queue and FROM the queue, avoiding copy of big objects.

Methods implemented:

  • Push(T&&) move an element to the queue
  • FrontAndPop() get the first element from the queue by moving it and remove it from the queue

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@jparisu
Copy link
Contributor Author

jparisu commented May 11, 2022

@richiprosima please test this

jparisu added 2 commits May 11, 2022 08:33
Signed-off-by: jparisu <[email protected]>
Signed-off-by: jparisu <[email protected]>
@jparisu jparisu changed the title DBQueue move Push and Pop methods DBQueue move Push and Pop methods [14537] May 11, 2022
@EduPonz EduPonz added this to the v2.7.0 milestone Jun 1, 2022
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and CI looks good!

@MiguelCompany MiguelCompany merged commit 20b5a6f into master Jul 1, 2022
@MiguelCompany MiguelCompany deleted the feature/dbqueue-move branch July 1, 2022 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants