Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18273] Refactor enum EntityKind::DOMAIN with EntityKind::DOMAIN_ENTITY #195

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mario-DL
Copy link
Member

In order to avoid a compilation issue with clang #184 a refactor of EntityKind::DOMAIN with EntityKind::DOMAIN_ENTITY.
This implies an API Break.

@Mario-DL Mario-DL temporarily deployed to codecov April 26, 2023 07:16 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (73a70d3) 58.46% compared to head (98d7de9) 58.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   58.46%   58.46%           
=======================================
  Files          38       38           
  Lines        4485     4485           
  Branches     2383     2383           
=======================================
  Hits         2622     2622           
  Misses         55       55           
  Partials     1808     1808           
Impacted Files Coverage Δ
src/cpp/database/database.cpp 52.62% <100.00%> (ø)
src/cpp/database/entities.hpp 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@srmainwaring
Copy link

srmainwaring commented Jul 10, 2023

Also checked on macOS Ventura 13.4, Xcode 14.3.1.

Issue is legacy BSD extensions to the C standard defined in MacOSX.sdk/usr/include/math.h.

If Fast-DDS-monitor is similarly patched the monitor builds and runs on macOS (good to have!).

Could this change please be merged, it's a pre-requisite for:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants