Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20509] Update repository for Fast DDS 3.0.0 compatibility #86

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

LuciaEchevarria99
Copy link
Contributor

@LuciaEchevarria99 LuciaEchevarria99 commented May 20, 2024

Signed-off-by: Lucia Echevarria <[email protected]>
@Tempate Tempate changed the title Update repository for Fast DDS 3.0.0 compatibility [20509] Update repository for Fast DDS 3.0.0 compatibility Jul 19, 2024
Signed-off-by: Lucia Echevarria <[email protected]>
@@ -14,7 +14,7 @@

#pragma once

#include <fastrtps/types/DynamicTypePtr.h>
#include <fastdds/dds/xtypes/dynamic_types/DynamicType.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include <fastdds/dds/xtypes/dynamic_types/DynamicType.hpp>


dynamic_type_topic_builder->set_name(topic.type_name);
dynamic_type_topic = dynamic_type_topic_builder->build();
// // Opción 1:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please tidy up.

fastrtps::types::DynamicDataHelper::print(dyn_data.get());
std::stringstream ss;
ss << std::setw(4);
auto ret = fastdds::dds::json_serialize(dyn_data, fastdds::dds::DynamicDataJsonFormat::EPROSIMA, ss);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Print error if not OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants