[21077] Update Fast DDS docs QoS examples #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
cferreiragonz
force-pushed
the
qos_api_review
branch
3 times, most recently
from
3d9dbb4 to
715a964
Compare
cferreiragonz
force-pushed
the
qos_api_review
branch
from
715a964 to
091c60f
Compare
|
@richiprosima please test_3 this |
Tempate
suggested changes
Jun 17, 2024
cferreiragonz
force-pushed
the
qos_api_review
branch
from
091c60f to
04b2e35
Compare
cferreiragonz
changed the title
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
cferreiragonz
force-pushed
the
qos_api_review
branch
from
04b2e35 to
d207cbd
Compare
|
@richiprosima please test_3 this |
cferreiragonz
added
ci-pending
ready-to-merge
and removed
needs-review
ci-pending
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the code examples of the QoS Policy to be more illustrative and include how the modified QoS should be used after editing it.
Additionally, it reviews that the API of QoS is identical for all entities that share a common QoS. It also makes the PropertyPolicyQoS of DataWriters and DataReader unmutable (such as the one of Participants), until a deeper study is made on what Policies should be mutable on enabled entities.
It also includes minor improvements in the readability of the docs (references, tabs, etc).
@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x
Contributor Checklist
Reviewer Checklist