Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20527] Ignore FASTDDS_TODO_BEFORE macro on doxygen generation #690

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Feb 27, 2024

Description

This PR predefines FASTDDS_TODO_BEFORE to empty so it is substitute with nothing on the pre-processing step of Doxygen documentation generation, and thus Doxygen does not complain about it.

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: Code snippets related to the added documentation have been provided.
  • N/A: Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@EduPonz EduPonz added this to the v2.14.0 milestone Feb 27, 2024
@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso
Copy link
Contributor

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x

Copy link

mergify bot commented Feb 27, 2024

backport 2.13.x 2.12.x 2.10.x 2.6.x

✅ Backports have been created

@EduPonz EduPonz merged commit 02065d0 into master Feb 27, 2024
4 checks passed
@EduPonz EduPonz deleted the hotfix/ignore_fastdds_todo_before branch February 27, 2024 09:29
mergify bot pushed a commit that referenced this pull request Feb 27, 2024
…neration (#690)

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit 02065d0)
mergify bot pushed a commit that referenced this pull request Feb 27, 2024
…neration (#690)

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit 02065d0)
mergify bot pushed a commit that referenced this pull request Feb 27, 2024
…neration (#690)

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit 02065d0)
mergify bot pushed a commit that referenced this pull request Feb 27, 2024
…neration (#690)

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit 02065d0)

# Conflicts:
#	code/doxygen-config.in
elianalf pushed a commit that referenced this pull request Feb 27, 2024
…neration (#690) (#692)

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit 02065d0)

Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
JesusPoderoso pushed a commit that referenced this pull request Feb 29, 2024
…neration (#690) (#691)

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit 02065d0)

Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Feb 29, 2024
…neration (#690) (#693)

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit 02065d0)

Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
Mario-DL pushed a commit that referenced this pull request Apr 16, 2024
* Predefine FASTDDS_TODO_BEFORE to empty so it is ignored on doxygen generation (#690)

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit 02065d0)

# Conflicts:
#	code/doxygen-config.in

* Refs #20527: Fix conflicts

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
Co-authored-by: JesusPoderoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants