Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20119] TCP socket send buffer limit #646

Merged
merged 3 commits into from
Feb 6, 2024
Merged

[20119] TCP socket send buffer limit #646

merged 3 commits into from
Feb 6, 2024

Conversation

jepemi
Copy link
Contributor

@jepemi jepemi commented Jan 16, 2024

Add non_blocking_send to TCPTransportDescriptor.

Merge after:

@JesusPoderoso JesusPoderoso added this to the v2.13.2 milestone Jan 18, 2024
MiguelCompany
MiguelCompany requested changes Jan 23, 2024
View reviewed changes
docs/fastdds/property_policies/non_consolidated_qos.rst Outdated Show resolved Hide resolved
docs/fastdds/property_policies/non_consolidated_qos.rst Outdated Show resolved Hide resolved
docs/fastdds/rtps_layer/rtps_layer.rst Outdated Show resolved Hide resolved
@jepemi jepemi mentioned this pull request Jan 24, 2024
Merged
14 tasks
@EduPonz EduPonz merged commit b74412f into master Feb 6, 2024
4 checks passed
@EduPonz EduPonz deleted the bugfix/tcp_buffer_limit_lock branch February 6, 2024 07:54
@EduPonz
Copy link

EduPonz commented Feb 6, 2024

@jepemi please order backports here

@jepemi
Copy link
Contributor Author

jepemi commented Feb 6, 2024

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

@mergify Mergify
Copy link

mergify bot commented Feb 6, 2024 •
edited
Loading

backport 2.12.x 2.11.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 6, 2024
@jepemi @mergify
TCP socket send buffer limit (#646)
22580bc 
* Refs #20119: Add non_blocking_send to TCPTransportDescriptor

Signed-off-by: Jesus Perez <[email protected]>

* Refs #20119: non_blocking_send moved to properties

Signed-off-by: Jesus Perez <[email protected]>

* Refs #20119: Apply suggestions

Signed-off-by: Jesus Perez <[email protected]>

---------

Signed-off-by: Jesus Perez <[email protected]>
(cherry picked from commit b74412f)

# Conflicts:
#	docs/fastdds/rtps_layer/rtps_layer.rst
mergify bot pushed a commit that referenced this pull request Feb 6, 2024
@jepemi @mergify
TCP socket send buffer limit (#646)
5c5707f 
* Refs #20119: Add non_blocking_send to TCPTransportDescriptor

Signed-off-by: Jesus Perez <[email protected]>

* Refs #20119: non_blocking_send moved to properties

Signed-off-by: Jesus Perez <[email protected]>

* Refs #20119: Apply suggestions

Signed-off-by: Jesus Perez <[email protected]>

---------

Signed-off-by: Jesus Perez <[email protected]>
(cherry picked from commit b74412f)

# Conflicts:
#	docs/fastdds/rtps_layer/rtps_layer.rst
This was referenced Feb 6, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Feb 6, 2024
@jepemi @mergify
TCP socket send buffer limit (#646)
8e0edc8 
* Refs #20119: Add non_blocking_send to TCPTransportDescriptor

Signed-off-by: Jesus Perez <[email protected]>

* Refs #20119: non_blocking_send moved to properties

Signed-off-by: Jesus Perez <[email protected]>

* Refs #20119: Apply suggestions

Signed-off-by: Jesus Perez <[email protected]>

---------

Signed-off-by: Jesus Perez <[email protected]>
(cherry picked from commit b74412f)

# Conflicts:
#	code/XMLTester.xml
#	docs/fastdds/rtps_layer/rtps_layer.rst
@mergify mergify bot mentioned this pull request Feb 6, 2024
Merged
mergify bot pushed a commit that referenced this pull request Feb 6, 2024
@jepemi @mergify
TCP socket send buffer limit (#646)
14d1fdc 
* Refs #20119: Add non_blocking_send to TCPTransportDescriptor

Signed-off-by: Jesus Perez <[email protected]>

* Refs #20119: non_blocking_send moved to properties

Signed-off-by: Jesus Perez <[email protected]>

* Refs #20119: Apply suggestions

Signed-off-by: Jesus Perez <[email protected]>

---------

Signed-off-by: Jesus Perez <[email protected]>
(cherry picked from commit b74412f)

# Conflicts:
#	code/XMLTester.xml
#	docs/fastdds/rtps_layer/rtps_layer.rst
@mergify mergify bot mentioned this pull request Feb 6, 2024
Merged
EduPonz
EduPonz reviewed Feb 14, 2024
View reviewed changes
docs/fastdds/rtps_layer/rtps_layer.rst
@@ -184,6 +184,7 @@ function of the :ref:`dds_layer_domainParticipantQos`, XML profiles (see :ref:`R
* |TCPTransportDescriptor::calculate_crc-api|, |TCPTransportDescriptor::check_crc-api| and
|TCPTransportDescriptor::apply_security-api| are set to false.
* |TCPTransportDescriptor::enable_tcp_nodelay-api| is set to true.
* :ref:`property_policies_tcp_non_blocking_send` is set to true.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is true anymore

EduPonz pushed a commit that referenced this pull request Feb 14, 2024
@mergify @jepemi
TCP socket send buffer limit (#646) (#656)
4503c33 
* TCP socket send buffer limit (#646)

* Refs #20119: Add non_blocking_send to TCPTransportDescriptor

Signed-off-by: Jesus Perez <[email protected]>

* Refs #20119: non_blocking_send moved to properties

Signed-off-by: Jesus Perez <[email protected]>

* Refs #20119: Apply suggestions

Signed-off-by: Jesus Perez <[email protected]>

---------

Signed-off-by: Jesus Perez <[email protected]>
(cherry picked from commit b74412f)

# Conflicts:
#	docs/fastdds/rtps_layer/rtps_layer.rst

* Refs #20119: Solve conflicts

Signed-off-by: Jesus Perez <[email protected]>

---------

Signed-off-by: Jesus Perez <[email protected]>
Co-authored-by: Jesús Pérez <[email protected]>
Co-authored-by: Jesus Perez <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Feb 21, 2024
@mergify @jepemi
TCP socket send buffer limit (#646) (#657)
c561639 
* TCP socket send buffer limit (#646)

* Refs #20119: Add non_blocking_send to TCPTransportDescriptor

Signed-off-by: Jesus Perez <[email protected]>

* Refs #20119: non_blocking_send moved to properties

Signed-off-by: Jesus Perez <[email protected]>

* Refs #20119: Apply suggestions

Signed-off-by: Jesus Perez <[email protected]>

---------

Signed-off-by: Jesus Perez <[email protected]>
(cherry picked from commit b74412f)

# Conflicts:
#	code/XMLTester.xml
#	docs/fastdds/rtps_layer/rtps_layer.rst

* Refs #20119: Solve conflicts

Signed-off-by: Jesus Perez <[email protected]>

---------

Signed-off-by: Jesus Perez <[email protected]>
Co-authored-by: Jesús Pérez <[email protected]>
Co-authored-by: Jesus Perez <[email protected]>
elianalf pushed a commit that referenced this pull request Mar 13, 2024
@mergify @jepemi
TCP socket send buffer limit (backport #646) (#655)
0d4b5b0 
* TCP socket send buffer limit (#646)

* Refs #20119: Add non_blocking_send to TCPTransportDescriptor

Signed-off-by: Jesus Perez <[email protected]>

* Refs #20119: non_blocking_send moved to properties

Signed-off-by: Jesus Perez <[email protected]>

* Refs #20119: Apply suggestions

Signed-off-by: Jesus Perez <[email protected]>

---------

Signed-off-by: Jesus Perez <[email protected]>
(cherry picked from commit b74412f)

# Conflicts:
#	docs/fastdds/rtps_layer/rtps_layer.rst

* Refs #20119: Solve conflicts

Signed-off-by: Jesus Perez <[email protected]>

---------

Signed-off-by: Jesus Perez <[email protected]>
Co-authored-by: Jesús Pérez <[email protected]>
Co-authored-by: Jesus Perez <[email protected]>
Mario-DL pushed a commit that referenced this pull request Apr 16, 2024
@mergify @jepemi
TCP socket send buffer limit (#646) (#658)
bb2e337 
* TCP socket send buffer limit (#646)

* Refs #20119: Add non_blocking_send to TCPTransportDescriptor

Signed-off-by: Jesus Perez <[email protected]>

* Refs #20119: non_blocking_send moved to properties

Signed-off-by: Jesus Perez <[email protected]>

* Refs #20119: Apply suggestions

Signed-off-by: Jesus Perez <[email protected]>

---------

Signed-off-by: Jesus Perez <[email protected]>
(cherry picked from commit b74412f)

# Conflicts:
#	code/XMLTester.xml
#	docs/fastdds/rtps_layer/rtps_layer.rst

* Refs #20119: Solve conflicts

Signed-off-by: Jesus Perez <[email protected]>

* Refs #20119: Remove non_blocking_send true from large data

Signed-off-by: Jesus Perez <[email protected]>

---------

Signed-off-by: Jesus Perez <[email protected]>
Co-authored-by: Jesús Pérez <[email protected]>
Co-authored-by: Jesus Perez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz left review comments

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.13.2
Development

Successfully merging this pull request may close these issues.
4 participants
@jepemi @EduPonz @MiguelCompany @JesusPoderoso