Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14528] Add documentation to the Fast DDS-Gen builtin annotations #368

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

JLBuenoLopez
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez commented May 10, 2022

Apart from adding documentation to the builtin annotations, this PR also fixes annotations @value and @default_literal which are still unimplemented.

Signed-off-by: JLBuenoLopez-eProsima [email protected]

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this ought to be changed in Fast DDS-Gen help as well

docs/fastddsgen/dataTypes/dataTypes.rst Outdated Show resolved Hide resolved
@JLBuenoLopez
Copy link
Contributor Author

Which help are you referring to? Fast DDS-Gen help only refers to the tool options and not to the annotation support or other implementation details. I do not think we should change this.

@JLBuenoLopez JLBuenoLopez changed the title [14528] @value annotation is unimplemented [14528] Add documentation to the Fast DDS-Gen builtin annotations May 23, 2022
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit c8d9346 into master Jun 8, 2022
@EduPonz EduPonz deleted the hotfix/value-annotation-unsupported branch June 8, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants