Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21636] Bump version to v4.0.1 and update IDL-Parser submodule #397

Merged
merged 2 commits into from
Sep 12, 2024
Merged

[21636] Bump version to v4.0.1 and update IDL-Parser submodule #397

merged 2 commits into from
Sep 12, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Sep 11, 2024 •
edited by Mario-DL
Loading

Description

This PR bumps the Fast DDS-Gen version to v4.0.1, and updates the IDL-Parser submodule with its latest release v4.0.1

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v4.0.1 milestone Sep 11, 2024
@JesusPoderoso JesusPoderoso changed the title [21636] Update IDL-Paser submodule with v4.0.1 [21636] Bump version to v4.0.1 and update IDL-Paser submodule Sep 11, 2024
@JesusPoderoso JesusPoderoso changed the title [21636] Bump version to v4.0.1 and update IDL-Paser submodule [21636] Bump version to v4.0.1 and update IDL-Parser submodule Sep 11, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 11, 2024
@JesusPoderoso JesusPoderoso removed the request for review from richiprosima September 11, 2024 11:34
Mario-DL
Mario-DL approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mario-DL Mario-DL removed the ci-pending PR which CI is running label Sep 12, 2024
@JesusPoderoso JesusPoderoso merged commit 997f3a5 into master Sep 12, 2024
4 checks passed
@JesusPoderoso JesusPoderoso deleted the feature/idlparser_v4.0.1 branch September 12, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@JesusPoderoso @Mario-DL