Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeObjectRegistry refactor [21148] #349

Merged
merged 6 commits into from
Jun 14, 2024
Merged

TypeObjectRegistry refactor [21148] #349

merged 6 commits into from
Jun 14, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Jun 5, 2024 •
edited by EduPonz
Loading

Description

With this refactor, any registration in TypeObjectRegistry will return a TypeIdentifierPair which a TopicDataType can use to configure internally DDS.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware
Refs #21044. Intermediate commit
8de9226 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #21044. Stable commit
21600ec 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #21044. Setting TopicDataType::type_identifiers_
9ef384c 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #21044. Fix warnings
fe3aa1c 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware changed the title TypeObjectRegistry refactor TypeObjectRegistry refactor [21148] Jun 5, 2024
@richiware
Refs #21044. More TryConstructKind standard
b60b2b4 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware force-pushed the feature/type-registry-refactor branch from 5430eea to 2e268e0 Compare June 7, 2024 06:25
@richiware
Refs #21044. More ExtensibilityKind standard
81779ba 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware force-pushed the feature/type-registry-refactor branch from 2e268e0 to 81779ba Compare June 7, 2024 09:30
adriancampo
adriancampo approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@adriancampo adriancampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CI: https://github.com/eProsima/Fast-DDS-Gen/actions/runs/9414840124

@EduPonz EduPonz merged commit 5aebc95 into master Jun 14, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/type-registry-refactor branch June 14, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriancampo adriancampo adriancampo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richiware @adriancampo @EduPonz