Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inheritance with aliases [20621] #316

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Fix inheritance with aliases [20621] #316

merged 2 commits into from
Mar 12, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Mar 12, 2024

This PR fixes an inheritance from an alias is not generated.

Depends on:

Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware changed the title Fix inheritance with aliases Fix inheritance with aliases [20621] Mar 12, 2024
@adriancampo
Copy link
Contributor

adriancampo commented Mar 12, 2024

Is it possible to detect this bug in some regression tests?

@richiware
Copy link
Member Author

Is it possible to detect this bug in some regression tests?

I believe not, because the test is already there, but the generated code is valid. I found the bug when writtind DynamicTypes with the inheritance.idl and found several structures are not inheriting.

@adriancampo
Copy link
Contributor

I thought that was going to be the case.
LGTM with green CI then.

Signed-off-by: Ricardo González Moreno <[email protected]>
@adriancampo
Copy link
Contributor

@richiware richiware merged commit b7bdf7e into master Mar 12, 2024
5 checks passed
@richiware richiware deleted the bugfix/20619 branch March 12, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants