Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Thread Pool Implementation #304

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Sep 15, 2022

New Enchanced Thread Pool Implementation with following characteristics:

  • Better performance (it is supposed to)
  • Easier to use
  • Support arguments

It requires #270

@jparisu jparisu temporarily deployed to codecov September 20, 2022 14:06 Inactive
@jparisu jparisu temporarily deployed to codecov September 20, 2022 14:06 Inactive
@jparisu jparisu marked this pull request as ready for review September 20, 2022 14:06
jparisu added 3 commits September 20, 2022 16:07
@jparisu jparisu temporarily deployed to codecov September 20, 2022 14:07 Inactive
@jparisu jparisu temporarily deployed to codecov September 20, 2022 14:07 Inactive
@jparisu jparisu changed the title TMP Thread Pool Implementation Enchanced Thread Pool Implementation Sep 20, 2022
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 53.19% // Head: 53.76% // Increases project coverage by +0.57% 🎉

Coverage data is based on head (b8b7bbf) compared to base (3a215f6).
Patch coverage: 68.34% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   53.19%   53.76%   +0.57%     
==========================================
  Files         104      121      +17     
  Lines        3848     3980     +132     
  Branches     1413     1467      +54     
==========================================
+ Hits         2047     2140      +93     
+ Misses        998      995       -3     
- Partials      803      845      +42     
Impacted Files Coverage Δ
...clude/ddsrouter_utils/wait/ConsumerWaitHandler.hpp 0.00% <ø> (ø)
...lude/ddsrouter_utils/thread/task/ArgsOwnedTask.hpp 50.00% <50.00%> (ø)
.../ddsrouter_utils/thread/task/ArgsReferenceTask.hpp 50.00% <50.00%> (ø)
.../ddsrouter_utils/wait/impl/ConsumerWaitHandler.ipp 75.00% <50.00%> (-9.22%) ⬇️
...e/ddsrouter_utils/wait/impl/DBQueueWaitHandler.ipp 35.71% <50.00%> (-8.74%) ⬇️
...uter_utils/src/cpp/thread/manager/AsyncManager.cpp 50.00% <50.00%> (ø)
...ter_utils/src/cpp/thread/manager/StdThreadPool.cpp 50.00% <50.00%> (ø)
...router_utils/src/cpp/thread/task/ReferenceTask.cpp 66.66% <66.66%> (ø)
...r_utils/thread/connector/impl/OneShotConnector.ipp 71.42% <71.42%> (ø)
...uter_utils/thread/connector/impl/SlotConnector.ipp 80.00% <80.00%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: jparisu <[email protected]>
@jparisu jparisu temporarily deployed to codecov September 20, 2022 14:27 Inactive
@jparisu jparisu temporarily deployed to codecov September 20, 2022 14:27 Inactive
@jparisu jparisu changed the title Enchanced Thread Pool Implementation Enhanced Thread Pool Implementation Sep 21, 2022
@jparisu jparisu temporarily deployed to codecov September 27, 2022 15:14 Inactive
@jparisu jparisu temporarily deployed to codecov September 27, 2022 15:14 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant