Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local DDS Router filtering #284

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Aug 24, 2022

This PR requires a Fast DDS PR to be merged: eProsima/Fast-DDS#2943

@jparisu jparisu temporarily deployed to codecov August 24, 2022 12:09 Inactive
@jparisu jparisu temporarily deployed to codecov August 24, 2022 12:09 Inactive
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Base: 58.37% // Head: 58.28% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (bab8f1a) compared to base (8d635a8).
Patch coverage: 41.07% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
- Coverage   58.37%   58.28%   -0.09%     
==========================================
  Files          99       99              
  Lines        3428     3459      +31     
  Branches     1277     1293      +16     
==========================================
+ Hits         2001     2016      +15     
- Misses        652      653       +1     
- Partials      775      790      +15     
Impacted Files Coverage Δ
...ore/src/cpp/writer/implementations/rtps/Writer.cpp 63.85% <0.00%> (ø)
...implementations/rtps/filter/RepeaterDataFilter.cpp 0.00% <0.00%> (ø)
...er_yaml/include/ddsrouter_yaml/impl/YamlReader.ipp 63.41% <ø> (ø)
...icipant/implementations/rtps/CommonParticipant.cpp 57.89% <39.02%> (-1.41%) ⬇️
...ter/implementations/rtps/filter/GuidDataFilter.cpp 60.00% <60.00%> (ø)
...ore/src/cpp/reader/implementations/rtps/Reader.cpp 65.00% <66.66%> (-2.00%) ⬇️
...clude/ddsrouter_utils/event/impl/SignalManager.ipp 72.88% <0.00%> (-3.39%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jparisu jparisu force-pushed the feature/local-router-filtering branch from e1bde81 to 6aa7b8c Compare September 6, 2022 10:27
@jparisu jparisu temporarily deployed to codecov September 6, 2022 10:27 Inactive
@jparisu jparisu temporarily deployed to codecov September 6, 2022 10:27 Inactive
Signed-off-by: jparisu <[email protected]>
@jparisu jparisu temporarily deployed to codecov September 6, 2022 10:39 Inactive
@jparisu jparisu temporarily deployed to codecov September 6, 2022 10:39 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant