Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change log threshold in blackbox tests #145

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Change log threshold in blackbox tests #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/blackbox/ddsrouter_core/dds/WAN/DDSTestWAN.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,8 @@ void test_WAN_communication(
std::string client_config_path)
{
// Check there are no warnings/errors
// TODO: Uncomment when having no listening addresses is no longer considered an error by the middleware
// TODO: Change threshold to \c Log::Kind::Warning once middleware warnings are solved
// test::TestLogHandler test_log_handler(Log::Kind::Error);
test::TestLogHandler test_log_handler(Log::Kind::Error);

uint32_t samples_sent = 0;
std::atomic<uint32_t> samples_received(0);
Expand Down
3 changes: 1 addition & 2 deletions test/blackbox/ddsrouter_core/dds/local/DDSTestLocal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ void test_local_communication(
std::string config_path)
{
// Check there are no warnings/errors
// TODO: Change threshold to \c Log::Kind::Warning once middleware warnings are solved
test::TestLogHandler test_log_handler(Log::Kind::Error);
test::TestLogHandler test_log_handler(Log::Kind::Warning);

uint32_t samples_sent = 0;
std::atomic<uint32_t> samples_received(0);
Expand Down