fix: remove patientId field, fixed next appointment bug, removed unus… #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/reports/edit/template.hbs
Outdated
| {{#if model.visit.startDate}} | ||
| <div class="ps-info-group"> | ||
| <label class="ps-info-label">{{t 'reports.form.visitDate' }}</label> | ||
| <input class="form-control" value={{date-format model.visit.startDate format="DD/MM/YYYY hh:mm a"}}> | ||
| <input class="form-control" disabled value={{date-format model.visit.startDate format="DD/MM/YYYY hh:mm a"}}> |
There was a problem hiding this comment.
The date field should be displayed just as text, not an input element. A tech-savvy/malicious user could tweak the disabled property of the input, and change the date.
Kindly implement this as text: <p> or <span>, not <input>
app/reports/edit/template.hbs
Outdated
| @@ -83,7 +78,7 @@ | |||
| {{#if nextAppointment}} | |||
| <div class="ps-info-group"> | |||
| <label class="ps-info-label">{{t 'reports.form.nextAppointmentDate' }}</label> | |||
| <input class="form-control" value={{date-format nextAppointment format="DD/MM/YYYY hh:mm a"}}> | |||
| <input class="form-control" disabled value={{date-format nextAppointment format="DD/MM/YYYY hh:mm a"}}> | |||
There was a problem hiding this comment.
The appointment field should also be text not input, as stated above
adeolabadmus
approved these changes
Feb 21, 2017
adeolabadmus
approved these changes
Feb 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues raised in sprint retro