Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

fix(odk): use payload filter with meta.instanceID #415

Merged
merged 3 commits into from
Oct 16, 2018

Conversation

obdulia-losantos
Copy link
Collaborator

Instead of using the instanceID filter why not the new payload__XXX one.

With this we make kernel more ODK agnostic that I think it's a good thing 😇

Hey! Did you know that we already reached 96% test coverage level in kernel? 😉

Name                                      Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------------------------
aether/__init__.py                            1      0      0      0   100%
aether/kernel/__init__.py                     1      0      0      0   100%
aether/kernel/admin.py                       35      0      0      0   100%
aether/kernel/api/__init__.py                 0      0      0      0   100%
aether/kernel/api/avro_tools.py             264      2    156      2    99%   354, 395, 353->354, 394->395
aether/kernel/api/constants.py                7      0      0      0   100%
aether/kernel/api/exporter.py               202      0     80      0   100%
aether/kernel/api/filters.py                 96      0     20      0   100%
aether/kernel/api/forms.py                   17      0      2      0   100%
aether/kernel/api/mapping_validation.py      50      0     16      0   100%
aether/kernel/api/models.py                 213      0     30      0   100%
aether/kernel/api/project_artefacts.py      120      0     57      0   100%
aether/kernel/api/serializers.py            180     15     24      8    88%   200-201, 322, 326-327, 339-344, 350, 353, 363-364, 367-368, 431, 319->321, 321->322, 335->337, 337->339, 347->350, 352->353, 354->356, 430->431
aether/kernel/api/urls.py                    15      0      0      0   100%
aether/kernel/api/utils.py                  341     40    160     10    87%   251, 255-257, 341, 344, 348-351, 365-386, 395-396, 432, 461-475, 518, 594-598, 601-602, 250->251, 338->341, 343->344, 345->348, 394->395, 429->432, 459->461, 515->518, 591->594, 600->601
aether/kernel/api/validators.py              39      0     18      0   100%
aether/kernel/api/views.py                  151      0     24      0   100%
aether/kernel/apps.py                         4      0      0      0   100%
aether/kernel/urls.py                         5      0      0      0   100%
-------------------------------------------------------------------------------------
TOTAL                                      1741     57    587     20    96%

Copy link
Contributor

@quesebifurcan quesebifurcan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I kept the instanceID filter there so as not to break any scripts depending on it, but if we can verify that no one is using it, I'm very much in favor of this simplification.

Copy link
Contributor

@admbtlr admbtlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 for the payload filter, btw - I've just been using it on the microcensus data

@obdulia-losantos
Copy link
Collaborator Author

The instance filter was only used in the ODK submission view

@obdulia-losantos obdulia-losantos merged commit f56f593 into develop Oct 16, 2018
@obdulia-losantos obdulia-losantos deleted the fix-odk-filters branch October 16, 2018 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants