-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homeobject side graceful shutdown #254
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
==========================================
- Coverage 63.15% 61.03% -2.13%
==========================================
Files 32 33 +1
Lines 1900 2564 +664
Branches 204 300 +96
==========================================
+ Hits 1200 1565 +365
- Misses 600 838 +238
- Partials 100 161 +61 ☔ View full report in Codecov by Sentry. |
start_shutting_down(); | ||
// Wait for all pending requests to complete | ||
while (true) { | ||
auto pending_reqs = get_pending_request_num(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
baseline resync be considered as HS or HO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will be considered as HS.
Homeobject side graceful shutdown will only make sure that when shutting down homeobject , there is no pending external (or user api) calls from upper layer and reject later api calls .
baseline resync is a mechanism of statemachin(raft), and all the baseline resync related code in homeobject is called by statemachine. homeobject can not do anything for this. so , we need to handle this in raft level (homestore).
i will try to submit another pr for homestore graceful shutdown.
this PR add counters to record the pending request and start shutdown homestore when no pending request
ab6ba94
to
023a31c
Compare
this PR add counters to record the pending request and start shutdown homestore when no pending request