Skip to content

fix: backport 6 upstream bug fixes (B10-B16)#17

Merged
e6qu merged 7 commits intodevfrom
fix/upstream-backports-p2
Mar 18, 2026
Merged

fix: backport 6 upstream bug fixes (B10-B16)#17
e6qu merged 7 commits intodevfrom
fix/upstream-backports-p2

Conversation

@e6qu
Copy link
Owner

@e6qu e6qu commented Mar 18, 2026

Summary

Phase 2 backport of upstream bug fixes, continuing from #16 (P1).

  • B10 — Add .describe() annotation to snapshot config field (upstream #17861)
  • B11 partial — Disable default plugins in test preload (upstream #17859)
  • B12 — Add Shell type and shell option to Process.spawn, wrap editor in try/finally for Windows support (upstream #17146)
  • B13 — Remove separate github-copilot-enterprise provider; use deployment mode instead (upstream #17847)
  • B14 — Fix org active label scoping to check both account ID and org ID (upstream #16957)
  • B16 — Fix review comment CSS overflow and button event handling (upstream #17948)

Skipped

  • B11 (most) — Production change requires Effect FileService; test timing refactors don't match our structure
  • B15 — Our llm.test.ts already uses SessionID.make() — fix not needed

Test plan

  • bun typecheck passes
  • bun test — 1401 tests pass, 0 failures
  • Manual: verify copilot enterprise login still works via deployment mode
  • Manual: verify inline review comments render without overflow

altendky and others added 7 commits March 18, 2026 02:31
Backport upstream #17861. Adds a descriptive annotation to the snapshot
boolean config field so tooling and docs can surface what it controls.
Backport upstream #17146. Adds Shell type and shell option to
Process.Options, and wraps editor open in try/finally so the renderer
always resumes even if the editor process throws.
…nt mode (B13)

Backport upstream #17847. Instead of maintaining a separate
github-copilot-enterprise provider ID, the copilot plugin now uses
the deploymentType to distinguish enterprise from public GitHub.
Backport upstream #16957. The old logic compared only the org ID,
so two accounts with the same org could both appear as "(active)".
Now checks both accountID and orgID together.
Backport upstream #17948. Adds min-width:0, box-sizing, and
overflow-wrap to prevent inline comment popover overflow. Also adds
mousedown preventDefault and click stopPropagation to cancel/submit
buttons so they don't steal focus or bubble events incorrectly.
Backport partial upstream #17859. Sets OPENCODE_DISABLE_DEFAULT_PLUGINS
in test preload to prevent default plugins from loading during tests.
@e6qu e6qu merged commit 3930dc1 into dev Mar 18, 2026
1 check passed
@e6qu e6qu deleted the fix/upstream-backports-p2 branch March 18, 2026 00:44
e6qu added a commit that referenced this pull request Mar 18, 2026
* fix: add .describe() annotation to snapshot config field (B10)

Backport upstream #17861. Adds a descriptive annotation to the snapshot
boolean config field so tooling and docs can surface what it controls.

* fix: add shell option to Process.spawn for Windows editor support (B12)

Backport upstream #17146. Adds Shell type and shell option to
Process.Options, and wraps editor open in try/finally so the renderer
always resumes even if the editor process throws.

* fix: remove separate github-copilot-enterprise provider, use deployment mode (B13)

Backport upstream #17847. Instead of maintaining a separate
github-copilot-enterprise provider ID, the copilot plugin now uses
the deploymentType to distinguish enterprise from public GitHub.

* fix: scope org active label to both account and org ID (B14)

Backport upstream #16957. The old logic compared only the org ID,
so two accounts with the same org could both appear as "(active)".
Now checks both accountID and orgID together.

* fix: review comment CSS overflow and button event handling (B16)

Backport upstream #17948. Adds min-width:0, box-sizing, and
overflow-wrap to prevent inline comment popover overflow. Also adds
mousedown preventDefault and click stopPropagation to cancel/submit
buttons so they don't steal focus or bubble events incorrectly.

* fix: disable default plugins in test preload (B11 partial)

Backport partial upstream #17859. Sets OPENCODE_DISABLE_DEFAULT_PLUGINS
in test preload to prevent default plugins from loading during tests.

---------

Co-authored-by: Kyle Altendorf <sda@fstab.net>
Co-authored-by: AbigailJixiangyuyu <61586456+AbigailJixiangyuyu@users.noreply.github.com>
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
Co-authored-by: Kit Langton <kit.langton@gmail.com>
Co-authored-by: Shoubhit Dash <shoubhit2005@gmail.com>
Co-authored-by: Luke Parker <10430890+Hona@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants