Adding vectorgroup dynyn to 3w-transformer #2283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added Dynyn vectorgroup to 3wtrafo
fixed ynyy, minor changes in dynyn
fixed typos
|
@nis-bucr thanks for this patch. Could you by any chance update the changelog? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2283 +/- ##
===========================================
- Coverage 76.47% 76.45% -0.02%
===========================================
Files 281 281
Lines 32580 32587 +7
===========================================
Hits 24915 24915
- Misses 7665 7672 +7 ☔ View full report in Codecov by Sentry. |
Added changelog for vecotrgroup addition
|
@vogt31337 Thank you for the review. I added the changelog message to upcoming release, hope this is correct. |
|
@nis-bucr thanks for updating. CodeCov reported that there is no test covering your changes/additions. Could you by any chance add a simple test for your dynyn 3w transformer? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The vectorgroup Dynyn was currently not supported for shortcircuit calculations of three winding transformers
Fix
Added the vectorgroup. Also fixed bug with vectorgroup Ynyy.