Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protobuf support #45

Closed
wants to merge 3 commits into from
Closed

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Feb 8, 2021

Adds protobuf files. I was following a naming "convention" I found in cosmos-sdk and other sdk based projects

  • proto stores the project protobuf files
  • third_party/proto contains all the dependencies. I copied them from cosmos-sdk to get started. We can remove unused ones later

Adds new targets to Makefile for protobuf generation and linting.

  • Uses Regen's gogobuf fork as in cosmos-sdk
  • Uses tendermintdev/sdk-proto-gen for protobuf generation
  • Uses bufbuild/buf dockerfile for formatting/linting with buf

Security notice: This PR add third party docker containers and tools to the build chain.

Introduces the package em.authority.v1beta1 for the project's protobuf. Please let me know if you have strong opinions on the naming.

The protobuf messages contain an X suffix for now to not cause conflicts with existing types. Otherwise they will be the replacement for them for the V0.41.0. Please note that sdk.AccAddress types were removed in all messages in favour of bech32 strings.

@alpe alpe requested a review from haasted February 8, 2021 11:35
@alpe alpe mentioned this pull request Feb 8, 2021
@alpe alpe closed this Feb 24, 2021
@alpe
Copy link
Contributor Author

alpe commented Feb 24, 2021

Obsolete by #48

@alpe alpe deleted the dev_stargate_add_protobuf branch February 24, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant