Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/v0.9.3 v2 best price in querier response #40

Merged
merged 3 commits into from
Dec 12, 2020
Merged

Hotfix/v0.9.3 v2 best price in querier response #40

merged 3 commits into from
Dec 12, 2020

Conversation

blewater
Copy link
Contributor

emcli tx market add-limit 50000eeur 45000echf
emcli tx market add-limit 45000echf 50000eeur
emcli tx market add-limit 50000eeur 45000echf
emcli tx market add-limit 45000echf 50000ejpy
emcli q market instruments

instruments:
- source: echf
  destination: eeur
  best_price: "1.111111111111111112"
  last_price: "1.111111111111111111"
  last_traded: 2020-12-11T14:24:32.9445431Z
- source: echf
  destination: ejpy
- source: echf
  destination: ungm
- source: eeur
  destination: echf
  last_price: "0.900000000000000000"
  last_traded: 2020-12-11T14:24:32.9445431Z
- source: eeur
  destination: ejpy
- source: eeur
  destination: ungm
- source: ejpy
  destination: echf
  best_price: "0.900000000000000001"
- source: ejpy
  destination: eeur
  best_price: "1.000000000000000001"
- source: ejpy
  destination: ungm
- source: ungm
  destination: echf
- source: ungm
  destination: eeur
- source: ungm
  destination: ejpy

blewater and others added 3 commits December 11, 2020 23:56
@blewater @mdyring
Move Best price field to response
8617482 
Adjust unit test cases to look for best price in querier response.
@blewater @mdyring
Remove commented code
29d345a
@mdyring
Update queries API
2291b7b
mdyring
mdyring approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@mdyring mdyring left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, output as expected given the orders provided. Let's merge.

Was it discussed to stay on the v0.9.3 version number for these fixes or bump to v0.9.4?

@blewater
Copy link
Contributor Author

Was it discussed to stay on the v0.9.3 version number for these fixes or bump to v0.9.4?

Just implied. 0.9.4 sounds better to me.

@blewater blewater merged commit 12b0302 into master Dec 12, 2020
@blewater blewater deleted the hotfix/v0.9.3 branch December 14, 2020 09:24
alpe added a commit that referenced this pull request Mar 17, 2021
@alpe
Merge branch 'develop' into dev_stargate_orm
18e0370 
* develop:
  Allow export of Liquidity Provider accounts
  Hotfix/v0.9.3 v2 best price in querier response (#40)
  Merge branch 'hotfix/v0.9.3'
  PR for issue 33 (#37)
  Move buildspec.yml to .aws
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdyring mdyring mdyring approved these changes

@haasted haasted Awaiting requested review from haasted

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blewater @mdyring