Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Test for new Dashboard feature #1161

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jiji14
Copy link
Contributor

@jiji14 jiji14 commented Jun 3, 2024

Overview

This PR includes unit tests for the new Dashboard feature.

Related PR

#1142

Details

Carousel Component

  1. Verify that scrolling functionality works correctly

DateSelect Component

  1. Ensure the Modal component opens upon clicking the button
  2. Confirm that the date range updates accurately
  3. Check that the onChoose function is called with the correct parameters

metricsHelper

  1. Revise getUniqueLabelsForDays test with duplicated labels
  2. Revise isCustomLabels for all sensed labels

@jiji14 jiji14 marked this pull request as draft June 3, 2024 19:39
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.94%. Comparing base (e55e5ae) to head (ae6fc3f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1161      +/-   ##
==========================================
+ Coverage   30.59%   30.94%   +0.34%     
==========================================
  Files         118      118              
  Lines        5216     5216              
  Branches     1154     1154              
==========================================
+ Hits         1596     1614      +18     
+ Misses       3618     3598      -20     
- Partials        2        4       +2     
Flag Coverage Δ
unit 30.94% <ø> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
www/js/components/Carousel.tsx 100.00% <ø> (ø)
www/js/diary/list/DateSelect.tsx 89.13% <ø> (+39.13%) ⬆️

... and 2 files with indirect coverage changes

@jiji14 jiji14 marked this pull request as ready for review June 7, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: PRs for review by pairs
Development

Successfully merging this pull request may close these issues.

1 participant