Ergonomics improvements (keypad_new and RefCell in release are no more) #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, and thank you for the library.
I hope this PR will be useful.
Motivation:
keypad_new
anywhere else other than the origin module;RefCell
wrapping;Thus, in this PR I removed
keypad_new
macro and implementednew
function in the main macro (RefCell wrapping included).As an additional improvement,
release
method now returns pins withoutRefCell
.(I don't really like the macro rule duplication, but it works.)