-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python runner module S28 #1320
base: master
Are you sure you want to change the base?
Conversation
@B1TC0R3 are there any plans to finalize this PR? |
Hello and sorry for the long pause. |
We can leave it open as draft or you can close it and improve it behind the scenes. Up to you. |
I will just leave it open then. |
My remaining todo before this is pull request is ready:
|
@m-1-k-3 Here's the updated documentation for the new module. Let me know if I missed anything. ^_^ emba_python_modules.md (Outdated, updated version here) |
The Codacy workflow uses Prospector and Pylint and has found multiple style issues. Could you take a look please. |
Since the pipeline uses prospector, I've also gone ahead and added that to |
I will do some further review and testing after #1452 ... in the meantime thank you for your work. Looking forward to dig into it |
Ah right, I almost forgot, there have been some minor updates to the documentation due to today's changes. |
I have reviewed the warnings identified by the pipeline and it can be broken down into two points:
Since these warnings might be thrown on every following pipeline run, I do intent to fix them but am unsure of how to go about it. What is your opinion on this problem? |
Sorry for the delay ... as we were quite busy we needed to postpone this PR to the next release. |
@@ -0,0 +1,158 @@ | |||
#!/usr/bin/python3 | |||
# pylint: disable=consider-using-with, no-member |
Check warning
Code scanning / Pylint (reported by Codacy)
Bad option value 'consider-using-with' Warning
@@ -0,0 +1,66 @@ | |||
#!/usr/bin/python3 | |||
# pylint: disable=broad-exception-caught |
Check warning
Code scanning / Pylint (reported by Codacy)
Bad option value 'broad-exception-caught' Warning
@@ -0,0 +1,158 @@ | |||
#!/usr/bin/python3 | |||
# pylint: disable=consider-using-with, no-member |
Check warning
Code scanning / Pylintpython3 (reported by Codacy)
Bad option value 'consider-using-with' Warning
@@ -0,0 +1,66 @@ | |||
#!/usr/bin/python3 | |||
# pylint: disable=broad-exception-caught |
Check warning
Code scanning / Pylintpython3 (reported by Codacy)
Bad option value 'broad-exception-caught' Warning
@@ -0,0 +1,158 @@ | |||
#!/usr/bin/python3 | |||
# pylint: disable=consider-using-with, no-member |
Check warning
Code scanning / Prospector (reported by Codacy)
Bad option value 'consider-using-with' (bad-option-value) Warning
@@ -0,0 +1,66 @@ | |||
#!/usr/bin/python3 | |||
# pylint: disable=broad-exception-caught |
Check warning
Code scanning / Prospector (reported by Codacy)
Bad option value 'broad-exception-caught' (bad-option-value) Warning
This is not an issue at all. I am, however, still confused on why pylint is throwing these warnings, specially since I am working on rewriting the Python code in a way where the disabled warnings would not be triggered in the first place, |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature.
What is the current behavior? (You can also link to an open issue here)
EMBA cannot run Python scripts natively as modules.
What is the new behavior (if this is a feature change)? If possible add a screenshot.
This PR adds a new module ("S28_python_run") with the capability of running user-supplied python scripts as
modules. Related to issue Python runner module #1264.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No. The module S28 is disabled in the default scan profile (
default-scan.emba
).In addition, when no Python scripts are manually specified, it will start and terminate without doing anything.
Other information:
This is a continuation of pull request Add module S28_python_run #1277.
As mentioned in my last commend there, I broke the Git history of my fork so badly that I had
to delete the it...
This new pull request also implements some changes I made to the logging mechanism.