Svcctl shall not steal ports

dzbarsky · Oct 10, 2024 · 3ef4e9b · 3ef4e9b
1 parent 106982e
commit 3ef4e9b
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/cmd/svcinit/main.go b/cmd/svcinit/main.go
@@ -107,10 +107,12 @@ func main() {
 	unversionedSpecs, err := readServiceSpecs(serviceSpecsPath)
 	must(err)
 
-	ports, err := assignPorts(unversionedSpecs)
+	// Make sure we grab the svcctl port before we assign test ports,
+	// otherwise we might steal an assigned port by accident.
+	listener, err := net.Listen("tcp", "127.0.0.1:0")
 	must(err)
 
-	listener, err := net.Listen("tcp", "127.0.0.1:0")
+	ports, err := assignPorts(unversionedSpecs)
 	must(err)
 
 	svcctlPort := listener.Addr().(*net.TCPAddr).Port