Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal): added ability to show view only public chat #8

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

ravindra-dyte
Copy link
Contributor

Linear Issue
fixes WEB-4023

Description

In case of dynamic permission change, Chat box was getting hidden due to the canViewChat check. Added canReceive similar to the chatPrivate.canReceive.

Note: Web Core equivalent is not added yet. It has to be added and the type casting has to be removed from this PR.

Steps to test

Run the following code snippet for presets that have everything disabled for public chats.

        Object.defineProperty(
            meeting?.self.permissions.chatPublic,
            "canReceive",
            {
                value: true
            }
        );

@ravindra-dyte ravindra-dyte requested a review from a team as a code owner September 24, 2024 05:55
@ravindra-dyte ravindra-dyte force-pushed the feat/WEB-4023-view-only-public-chat branch from f67feec to 17d8b7a Compare September 24, 2024 06:25
@ravindra-dyte ravindra-dyte changed the title feat(view-only-public-chat): added ability to show view only public chat feat(internal): added ability to show view only public chat Sep 24, 2024
@ravindra-dyte ravindra-dyte merged commit 88f865f into staging Sep 25, 2024
5 checks passed
@ravindra-dyte ravindra-dyte deleted the feat/WEB-4023-view-only-public-chat branch September 25, 2024 06:54
Copy link

🎉 This PR is included in version 2.1.0-staging.15 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants