chore(gitignore): remove stray hand-maintained **/.codex/memories/ entry - #2009
Merged
Merged
Conversation
Follow-up to #1979 (#1980 #1): after codexcli stopped emitting inert .codex/memories/ files (non-root rules now fold into root AGENTS.md), a **/.codex/memories/ line was left orphaned in the user-maintained zone of .gitignore, above the '# Generated by Rulesync' header. rulesync no longer references that directory, so the entry is dead cruft and pnpm dev gitignore neither emits nor strips it. Remove it. Closes #1980 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1979, addressing finding #1 (mid) in #1980.
PR #1979 made codexcli fold non-root rules into the root
AGENTS.mdand stop emitting inert.codex/memories/*files. It correctly removed**/.codex/memories/from the auto-generated# Generated by Rulesyncsection, but a stray**/.codex/memories/line was left in the user-maintained zone of.gitignore(betweendocs/.vitepress/cacheand the generated header).Since
gitignore-entries.ts/gitignore-derive.tsno longer referencecodex/memories, the string is not inALL_GITIGNORE_ENTRIES, sopnpm dev gitignoreneither emits nor strips it — it is orphaned cruft. This removes it.The remaining findings in #1980 are low/no-action: #2 (legacy
.codex/memories/*.mdno longer auto-cleaned — accepted tradeoff matching the grokcli/warp/deepagents precedent) and #3 (informational,excludeToolDirparity).Verification
pnpm cicheckpasses;pnpm dev gitignorereports "already up to date" (the removal is stable — the generator does not re-add the line), satisfying thegitignore-entries.test.ts/gitignore.test.tsnot.toContain("**/.codex/memories/")assertions.Closes #1980