fix(rovodev): preserve skill compatibility frontmatter on round-trip - #1996
Merged
Merged
Conversation
RovodevSkillFrontmatterSchema declared name/description/allowed-tools/license/ metadata but not compatibility, and toRulesyncSkill/fromRulesyncSkill map fields explicitly, so the documented optional Agent Skills compatibility field was silently dropped on round-trip (a residual of #1696). Add compatibility (free-form string, object form accepted for back-compat) to RovodevSkillFrontmatterSchema and the rulesync skill rovodev section, and carry it through both round-trip mappings — mirroring the agentsskills/vibe adapters. Refs #1986 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #1986. Fixes the skills sub-gap:
RovodevSkillFrontmatterSchemadeclaredname/description/allowed-tools/license/metadatabut notcompatibility, andtoRulesyncSkill/fromRulesyncSkillmap fields explicitly, so the documented optional Agent Skillscompatibilityfield was silently dropped on round-trip (a residual of #1696).Changes
compatibility(free-form string; object form accepted for back-compat) toRovodevSkillFrontmatterSchemaand to the rulesync skillrovodevsection schema/type.compatibilitythrough both round-trip mappings, mirroring theagentsskills/vibeadapters.file-formatsdocs.Deferred: event-hooks adapter
The issue's primary gap — a
RovodevHooksadapter writing theeventHooksblock into~/.rovodev/config.yml— is intentionally not implemented here. The exacteventHooksYAML schema is not officially documented: it is a preview feature surfaced only via the interactive/hookscommand, and both primary sources (the Atlassian blog and the settings docs) describe the interactive flow without publishing the literal key/nesting structure. The issue itself flags this: "Confirm the schema against a live/hooks help/ config dump before implementing." Implementing it now would mean inventing a schema that could emit config Rovo Dev cannot read, so it remains blocked on schema confirmation. This PR usesRefs(notCloses) so #1986 stays open for the hooks work.Test
pnpm cicheck(code + content) passes.Refs #1986