feat(skills): support root-level disable-model-invocation with per-target overrides - #1928
Merged
dyoshikawa merged 1 commit intoJun 19, 2026
Conversation
…rget overrides Users can now set disable-model-invocation once at the rulesync skill frontmatter root and have it applied to every supported tool (claudecode, cursor, zed, pi, qwencode, factorydroid). A value set inside a tool section still wins, so single-target opt-outs remain possible.
Owner
|
@sybers Thank you! |
dyoshikawa
pushed a commit
to hernaninverso/rulesync
that referenced
this pull request
Jun 19, 2026
PR dyoshikawa#1928 wired a root-level `disable-model-invocation` default into six tools, but factorydroid lacked a per-target section schema, so it could not honor a per-tool override and dropped the value on import — contradicting the documented "any tool section can override" claim. - Add a `factorydroid` section (with `disable-model-invocation`) to the rulesync skill frontmatter schema and input type. - Resolve the value in FactorydroidSkill.fromRulesyncSkill via the shared helper (root default + per-target override) and round-trip it back into the `factorydroid` section in toRulesyncSkill, matching the other five tools. - Extract a shared `resolveDisableModelInvocation` helper and replace the copy-pasted resolution expression in all six tool skill files (claudecode, cursor, zed, pi, qwencode, factorydroid). - Document the `factorydroid` skill section and re-sync skills/rulesync/. - Add unit tests for the helper and for factorydroid per-target override (including the `false`-over-`true` edge case) and import round-trip. Ref: dyoshikawa#1928 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can now set
disable-model-invocationonce at the rulesync skill frontmatter root and have it applied to every supported tool (claudecode,cursor,zed,pi,qwencode,factorydroid).A value set inside a tool section still wins, so single-target opt-outs remain possible.