fix(warp): correct Windows permissions settings.toml path to LOCALAPPDATA/config - #1873
Merged
Merged
Conversation
…DATA/config Follow-up from #1871. Warp's documented Windows (Stable) settings file is `%LOCALAPPDATA%\warp\Warp\config\settings.toml`, but `WARP_WIN32_DIR` pointed at `AppData/Roaming/warp/Warp/data` — wrong on both axes (Roaming vs Local, data vs config). As a result `rulesync generate --targets warp --features permissions --global` wrote the command allow/deny lists to a path Warp never reads on Windows, so the rules silently took no effect there. macOS and Linux were already correct. - Point `WARP_WIN32_DIR` at `AppData/Local/warp/Warp/config`. - Update the stale doc comment in `warp-permissions.ts` and the Windows path in `docs/reference/file-formats.md`. - Update the Windows expectation in `warp-permissions.test.ts`. Closes #1871
Address review finding: the e2e-permissions spec still referenced the old `AppData/Roaming/warp/Warp/data` Windows path; align it with the corrected `AppData/Local/warp/Warp/config` so the Windows e2e runner reads the right file.
The corrected Warp Windows path comment references %LOCALAPPDATA%.
Owner
Author
|
@dyoshikawa Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Follow-up from #1871.
Warp's documented Windows (Stable) settings file is
%LOCALAPPDATA%\warp\Warp\config\settings.toml(verified against Warp's settings file-locations doc). ButWARP_WIN32_DIRpointed atAppData/Roaming/warp/Warp/data— wrong on both axes:Roaminginstead ofLocal, and thedatasubfolder instead ofconfig.As a result,
rulesync generate --targets warp --features permissions --globalwrote theagent_mode_command_execution_allowlist/denylistto a path Warp never reads on Windows, so command permissions silently took no effect for Windows users. macOS (~/.warp/settings.toml) and Linux (~/.config/warp-terminal/settings.toml) were already correct.Changes
WARP_WIN32_DIRatAppData/Local/warp/Warp/config(maps%LOCALAPPDATA%).warp-permissions.tsand the Windows path indocs/reference/file-formats.md(synced toskills/rulesync/).warp-permissions.test.ts.All checks pass via
pnpm cicheck.Closes #1871