Skip to content

ci(e2e): drop unsupported macos-15-intel runner and set fail-fast: false - #1780

Merged
dyoshikawa merged 1 commit into
mainfrom
fix-ci-drop-macos-intel-e2e-runner
Jun 9, 2026
Merged

ci(e2e): drop unsupported macos-15-intel runner and set fail-fast: false#1780
dyoshikawa merged 1 commit into
mainfrom
fix-ci-drop-macos-intel-e2e-runner

Conversation

@dyoshikawa

Copy link
Copy Markdown
Owner

Summary

The macos-15-intel (Intel macOS) E2E leg in e2e-binaries.yml fails at the Setup mise step, before any test runs:

mise ERROR Failed to install aqua:pnpm/pnpm@latest: unsupported env: darwin/amd64
(supported: ["linux", "windows", "darwin/arm64"])

mise resolves pnpm through the aqua backend (aqua:pnpm/pnpm), which no longer publishes a darwin/amd64 build. This is an upstream toolchain limitation outside this project's control, and it currently breaks the E2E workflow on main and every PR (e.g. the latest main commit 3e1b0c06).

Because the matrix used the default fail-fast: true, this single platform failure also cancelled the ubuntu-latest / macos-latest / windows-latest legs, masking their otherwise-passing results.

Changes

  • Remove macos-15-intel from the E2E matrix, since GitHub-hosted Intel macOS runners can no longer bootstrap the toolchain.
  • Add fail-fast: false so a future single-platform breakage no longer cancels (and hides) the other legs.
  • Replace the now-unreachable Intel branch in the Unix binary-path selector with an explicit error, so a newly added Unix platform cannot silently fall through to testing the wrong binary.

Trade-off

The dist-bun/rulesync-darwin-x64 binary is still built, but it is no longer smoke-tested natively (this leg was its only native runner). If Intel macOS coverage must be retained, pnpm would need to be installed off the aqua backend instead — e.g. npm:pnpm in mise.toml, or corepack. I kept this PR to the minimal, guaranteed-green fix; happy to switch to the coverage-preserving approach if you prefer.

Why this PR is separate / not auto-merged

This change touches a GitHub Actions workflow (high-risk per the autonomous scrap-issue flow), so it is intentionally opened for manual review and merge rather than auto-merged. It unblocks CI so the in-flight scrap-issue PRs (starting with #1779) can go green and merge.

Verification

  • pnpm cicheck passes locally (format, lint, typecheck, 6049 tests, content checks).
  • This PR's own E2E run exercises the updated workflow.

🤖 Generated with Claude Code

The macos-15-intel (Intel macOS) E2E leg fails at the Setup mise step because mise installs pnpm via the aqua backend (aqua:pnpm/pnpm), which dropped darwin/amd64 support: "unsupported env: darwin/amd64 (supported: [linux, windows, darwin/arm64])". This is an upstream toolchain limitation outside the project's control and currently breaks E2E on main and every PR.

Because the matrix used the default fail-fast: true, this single platform failure also cancelled the ubuntu/macos-latest/windows legs, masking their (passing) results.

Remove the macos-15-intel leg from the matrix and add fail-fast: false so the remaining platforms always report their own status. The Unix binary-path selector's former Intel branch is now an explicit error to avoid silently testing the wrong binary if a new Unix platform is added.

Trade-off: the darwin-x64 binary is still built but no longer smoke-tested natively, since GitHub-hosted Intel macOS runners can no longer bootstrap the toolchain. If Intel coverage must be retained, pnpm would need to be installed off the aqua backend (e.g. npm:pnpm in mise.toml or corepack).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@dyoshikawa
dyoshikawa merged commit 3db65d3 into main Jun 9, 2026
11 checks passed
@dyoshikawa
dyoshikawa deleted the fix-ci-drop-macos-intel-e2e-runner branch June 9, 2026 07:51
@dyoshikawa

Copy link
Copy Markdown
Owner Author

@dyoshikawa Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants