ci(e2e): drop unsupported macos-15-intel runner and set fail-fast: false - #1780
Merged
Conversation
The macos-15-intel (Intel macOS) E2E leg fails at the Setup mise step because mise installs pnpm via the aqua backend (aqua:pnpm/pnpm), which dropped darwin/amd64 support: "unsupported env: darwin/amd64 (supported: [linux, windows, darwin/arm64])". This is an upstream toolchain limitation outside the project's control and currently breaks E2E on main and every PR. Because the matrix used the default fail-fast: true, this single platform failure also cancelled the ubuntu/macos-latest/windows legs, masking their (passing) results. Remove the macos-15-intel leg from the matrix and add fail-fast: false so the remaining platforms always report their own status. The Unix binary-path selector's former Intel branch is now an explicit error to avoid silently testing the wrong binary if a new Unix platform is added. Trade-off: the darwin-x64 binary is still built but no longer smoke-tested natively, since GitHub-hosted Intel macOS runners can no longer bootstrap the toolchain. If Intel coverage must be retained, pnpm would need to be installed off the aqua backend (e.g. npm:pnpm in mise.toml or corepack). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
Author
|
@dyoshikawa Thank you! |
dyoshikawa
pushed a commit
that referenced
this pull request
Jun 9, 2026
dyoshikawa
pushed a commit
that referenced
this pull request
Jun 9, 2026
dyoshikawa
pushed a commit
that referenced
this pull request
Jun 9, 2026
dyoshikawa
pushed a commit
that referenced
this pull request
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
macos-15-intel(Intel macOS) E2E leg ine2e-binaries.ymlfails at the Setup mise step, before any test runs:miseresolvespnpmthrough the aqua backend (aqua:pnpm/pnpm), which no longer publishes adarwin/amd64build. This is an upstream toolchain limitation outside this project's control, and it currently breaks the E2E workflow onmainand every PR (e.g. the latestmaincommit3e1b0c06).Because the matrix used the default
fail-fast: true, this single platform failure also cancelled theubuntu-latest/macos-latest/windows-latestlegs, masking their otherwise-passing results.Changes
macos-15-intelfrom the E2E matrix, since GitHub-hosted Intel macOS runners can no longer bootstrap the toolchain.fail-fast: falseso a future single-platform breakage no longer cancels (and hides) the other legs.Trade-off
The
dist-bun/rulesync-darwin-x64binary is still built, but it is no longer smoke-tested natively (this leg was its only native runner). If Intel macOS coverage must be retained,pnpmwould need to be installed off the aqua backend instead — e.g.npm:pnpminmise.toml, orcorepack. I kept this PR to the minimal, guaranteed-green fix; happy to switch to the coverage-preserving approach if you prefer.Why this PR is separate / not auto-merged
This change touches a GitHub Actions workflow (high-risk per the autonomous scrap-issue flow), so it is intentionally opened for manual review and merge rather than auto-merged. It unblocks CI so the in-flight scrap-issue PRs (starting with #1779) can go green and merge.
Verification
pnpm cicheckpasses locally (format, lint, typecheck, 6049 tests, content checks).🤖 Generated with Claude Code