Skip to content

fix(codexcli-mcp): remove dead logger parameter in convertToCodexFormat #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dyoshikawa merged 2 commits into from
Jun 9, 2026
+3 −6
Merged

fix(codexcli-mcp): remove dead logger parameter in convertToCodexFormat #1779

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5b1a7e
fix(codexcli-mcp): remove dead logger parameter in convertToCodexFormat
cm-dyoshikawa Jun 9, 2026
104c877
Merge origin/main: pull in CI workflow fix (#1780)
cm-dyoshikawa Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/features/mcp/codexcli-mcp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,7 @@ function convertFromCodexFormat(codexMcp: Record<string, unknown>): McpServers {
return result;
}

function convertToCodexFormat(
mcpServers: McpServers,
logger?: import("../../utils/logger.js").Logger,
): Record<string, unknown> {
function convertToCodexFormat(mcpServers: McpServers): Record<string, unknown> {
const result: Record<string, Record<string, unknown>> = {};

for (const [name, config] of Object.entries(mcpServers)) {
Expand All @@ -88,7 +85,7 @@ function convertToCodexFormat(
converted[mappedKey] = value;
} else {
warnWithFallback(
logger,
undefined,
`[CodexCliMcp] Skipping invalid value type for mapped key '${key}': expected string array, got ${typeof value}`,
);
}
Expand Down Expand Up @@ -197,7 +194,7 @@ export class CodexcliMcp extends ToolMcp {
];
}),
);
const converted = convertToCodexFormat(mcpServersWithCodexFields, undefined);
const converted = convertToCodexFormat(mcpServersWithCodexFields);
const filteredMcpServers = this.removeEmptyEntries(converted);

for (const name of Object.keys(converted)) {
Expand Down
Loading