feat(commands): add goal-pr and goal-all-scrap-issues commands - #1778
Merged
Conversation
Add two new rulesync command definitions: - goal-pr: drives a PR to merge by running /review-pr, fixing every mid-or-above finding, and repeating until a review round is clean, then merging via /merge-pr. - goal-all-scrap-issues: processes every open maintainer-scrap issue one at a time, fact-checking each with web research, closing the ones that need no action, and running /goal-pr to fix, review, and merge the ones that do. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Address code/security review findings on PR #1778: - Make green CI part of goal-pr's exit condition and merge precondition; never admin-bypass failing/pending checks. - Escalate high-risk changes (CI workflows, build/release config, dependency manifests) instead of auto-merging. - Treat untrusted issue/comment/web content strictly as data, not instructions, to limit prompt-injection into the auto-merge chain. - Push via 'git push origin HEAD' and stage only changed files; require a clean working tree before the auto-PR path. - Clarify issue ordering, mandatory Closes line, and marking capped issues as processed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
Author
|
@dyoshikawa Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add two new rulesync command definitions under
.rulesync/commands/(targets:*).goal-pr— Drives a pull request all the way to merge. It runs/review-pr, fixes every finding of severitymidor above, and repeats until a review round reports nomid-or-above findings, then merges via/merge-pr. If no PR exists yet, it opens one with/commit-push-prfirst. A hard cap of 10 iterations prevents infinite loops.goal-all-scrap-issues— Builds on/resolve-scrap-issues. Processes every openmaintainer-scrapissue one at a time: fact-checks each with web research, closes the ones that need no action, and runs/goal-prto fix, review, and merge the ones that do. Repeats until no actionable scrap issues remain (hard cap of 20 issues per run).Notes
agent-team,review-pr,resolve-scrap-issues)..rulesync/commands/*.mdfiles are committed.Test plan
pnpm cicheck:code— typecheck + lint + 6049 tests pass.pnpm cicheck:content— cspell + secretlint + skill-docs sync pass.pnpm dev generate --targets claudecode --features commands.🤖 Generated with Claude Code