feat: Agent Skills global scope + frontmatter, Copilot excludeAgent value + skill allowed-tools - #1775
Merged
Merged
Conversation
…alue + skill allowed-tools Batch follow-up of maintainer-scrap upstream issues: #1684 (Agent Skills): support the standard personal/global location ~/.agents/skills/ for the agentsskills target (supportsGlobal: true; getSettablePaths no longer throws on global), and pass the spec-standard optional frontmatter (license, compatibility, metadata, allowed-tools) through generation/import via a new rulesync agentsskills skill section. #1686 (GitHub Copilot): accept the documented excludeAgent value cloud-agent (keeping coding-agent as a deprecated alias) in the copilot rule + rulesync rule schemas; add allowed-tools to the copilot skill frontmatter (CopilotSkill + rulesync copilot section). (The Copilot hook events, global subagents, and global skills remain follow-ups.) Closes #1684 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dyoshikawa
pushed a commit
that referenced
this pull request
Jun 9, 2026
Resolve conflicts from upstream Goose hooks (#1770) and Agent Skills (#1775): - src/types/hooks.ts: keep both new HookEvent members (workspaceOpen + messageDisplay) - src/features/skills/rulesync-skill.ts: keep both new skill sections (cursor + agentsskills) in schema and input type - docs/reference/file-formats.md: merge the hook matrix to 16 columns (incl. Goose), re-applying #1774's changes (workspaceOpen row, deepagents notification, Factory Droid permissionRequest/setup cleanup) on top of the upstream messageDisplay row; regenerate skills/rulesync/file-formats.md via the docs sync script Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dyoshikawa
pushed a commit
that referenced
this pull request
Jun 9, 2026
Resolve conflicts from upstream Agent Skills (#1775): - src/features/skills/rulesync-skill.ts: keep both new skill sections (rovodev + agentsskills) in schema and input type - docs/reference/file-formats.md: re-apply #1772's frontmatter examples (roo command `mode`, rovodev skill block) onto the upstream version; regenerate skills/rulesync/file-formats.md Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dyoshikawa
pushed a commit
that referenced
this pull request
Jun 9, 2026
…view findings Resolve conflicts from upstream Agent Skills (#1775): - src/features/skills/skills-processor.test.ts: keep both new global targets (agentsskills + amp), ordered to match skillsProcessorToolTargetsGlobal - docs/reference/supported-tools.md: re-apply #1771's Amp Skills (✅ 🌏) cell onto the upstream matrix; regenerate skills/rulesync/supported-tools.md Address PR #1771 review findings (mid severity): - src/features/takt-shared.ts: extract the shared unsafe-name predicate into isUnsafeTaktName(), removing the duplication between assertSafeTaktName() and prependTaktExtends() (behavior-preserving) - src/e2e/e2e-skills.spec.ts: add amp to the global-mode skills E2E matrix (~/.config/agents/skills/), restoring Tool x Feature happy-path coverage for the newly global-capable target Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch follow-up of maintainer-scrap upstream issues, all primary-source verified.
#1684 — Agent Skills: global scope + optional standard frontmatter (fully resolved)
agentsskillstarget now supports the standard personal/global location~/.agents/skills/(supportsGlobal: true;getSettablePathsno longer throws on global; the relative path is the same and the resolution root is supplied by the processor).license,compatibility,metadata, andallowed-toolsare now passed through generation/import via a new rulesyncagentsskillsskill section, instead of being dropped.#1686 — GitHub Copilot:
excludeAgentvalue + skillallowed-tools(partial)excludeAgentvalue drift — the documented values arecode-reviewandcloud-agent, but the schema only acceptedcoding-agent. Now acceptscloud-agent(the current value) while keepingcoding-agentas a deprecated alias so existing configs still import.allowed-tools— added the optionalallowed-toolsfrontmatter to thecopilotskill namespace (CopilotSkill+ the rulesynccopilotskill section), mirroring the sibling skill blocks.Validation evidence (primary sources)
~/.agents/skills/,license/compatibility/metadata/allowed-tools): https://agentskills.io/specificationexcludeAgentvalues: https://docs.github.com/en/copilot/how-tos/configure-custom-instructions/add-repository-instructionsallowed-tools: https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-cloud-agent/add-skillsTest plan
pnpm cicheck— green (fmt, oxlint, typecheck, 5990 unit tests, sync-skill-docs, cspell, secretlint).cloud-agentacceptance; Copilot skillallowed-toolsround-trip.agentsskillsto the global-mode skills happy-path.e2e-skillspasses in full. (Note:e2e-ruleshas one pre-existing, unrelated environmental flake — a test assertingstderr === ""that trips on a NodeDEP0205 module.register()deprecation warning from tsx; it is independent of this change.)Note on the third newest issue (#1687, Copilot CLI)
Deferred: #1687 (Copilot CLI hooks
agentStop/cwd/env+ newhttp/prompthook types + a new skills adapter) is a larger effort that extends the canonical hook model (newhttptype, per-hookcwd/env) and overlaps #1686 on the shared Copilot hook-event set, so it warrants a dedicated, coherent change rather than a partial here.Linked issues
~/.agents/skills/scope and optional SKILL.md frontmatter #1684excludeAgentvalue, and global agents/skills #1686 (excludeAgent value + skill allowed-tools)🤖 Generated with Claude Code