feat(zed): skills, rules, mcp + git-transport root-path follow-ups - #1720
Merged
Conversation
…llow-ups Zed (#1705): add ZedSkill (.agents/skills/), ZedRule (root .rules + global ~/.config/zed/AGENTS.md), and ZedMcp (context_servers in .zed/settings.json, merged so the ignore feature's private_files survive). Register all three in their processors, add gitignore entries, update the README/docs support matrix, and add e2e cells. Previously the zed target only supported ignore. git-transport (#1718): normalize skillsPath before the repo-root check so '\''./.'\'', '\''.//'\'' and Windows '\''.\\'\'' also disable sparse-checkout; tighten the root-path regression test to distinguish fixed vs unfixed; add a wildcard x repo-root integration test; and document that path '\''""'\''/'\''"."'\'' fetches the whole repository. antigravity-cli subagents (#1706): confirmed via the official docs that CLI subagents are defined and managed only at runtime (the /agents panel and invoke_subagent/define_subagent tools) or bundled inside plugins, with no standalone declarative per-agent file rulesync could generate. Documented as out of scope in the migration guide. Refs: #1705, #1718, #1706 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Owner
Author
|
@dyoshikawa Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves three open
maintainer-scrapissues together.Zed: skills, rules, and MCP (#1705)
The
zedtarget previously supported onlyignore. This adds:ZedSkillwriting.agents/skills/<name>/SKILL.md(project) and~/.agents/skills/(global).ZedRulewriting the project.rulesfile (first in Zed's priority list) and the global~/.config/zed/AGENTS.md. Root-only, since Zed reads exactly one rules file.ZedMcpwriting thecontext_serverskey in.zed/settings.json(project) /~/.config/zed/settings.json(global). Reads/writes merge into the existing JSON so the ignore feature'sprivate_files(which shares the same file) is preserved. Env references pass through unchanged.Registered all three in their processors, added gitignore entries, updated the README/
docssupport matrix, and added e2e happy-path cells (generate / import / global).git-transport root-path follow-ups (#1718)
Follow-ups from the PR #1711 review:
skillsPathbefore the repo-root check so"./.",".//", and Windows".\\"also disable sparse-checkout instead of re-triggering the original bug.skills: ["*"]) × repo-root (path: ".") integration test insources.test.ts.path: ""/"."/"./"fetches the whole repository root.antigravity-cli subagents (#1706)
Verified via the official Antigravity docs (rendered with
playwright-cli) that CLI subagents are defined/managed only at runtime — the interactive/agentspanel and theinvoke_subagent/define_subagenttools — or bundled inside plugins. There is no standalone, declarative per-agent file (analogous togeminicli's.gemini/agents/) that rulesync could generate, so subagents remain out of scope. Refined the migration guide to record this conclusion. No generator added.Related issues
Test plan
pnpm cicheck(lint, types, format, 5799 unit/integration tests, content/spelling/secrets) — greenzed-skill.test.ts,zed-rule.test.ts,zed-mcp.test.tsgit-client.test.tsandsources.test.tse2e-skills,e2e-rules,e2e-mcppass with the newzedcellspnpm dev gitignoreproduces no spurious diff