fix(kilo-subagent): align read defaults - #1635
Merged
dyoshikawa merged 1 commit intoMay 14, 2026
Merged
Conversation
Contributor
|
Thank you for your contribution! Unfortunately, you currently have 3 open PRs (including this one), which exceeds the limit of 2 for external contributors. Please wait for an existing PR to be reviewed/merged, or close one before opening a new one. See CONTRIBUTING.md for details. |
Owner
|
@sirmacik Thank you! |
Merged
2 tasks
dyoshikawa
pushed a commit
that referenced
this pull request
May 21, 2026
subagents-processor.ts calls forDeletion with global: this.global, but OpenCodeSubagent.forDeletion did not destructure it, so the flag was silently dropped and the constructed placeholder always defaulted to global: false. Mirror the fix already applied to KiloSubagent.forDeletion in PR #1635 — destructure global from the params and forward it to the constructor. No behavior change for project-scope deletion; closes the second follow-up item tracked in #1639.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft follow-up for #1634. This addresses the Kilo subagent default-mode cleanup from the maintainer-scrap issue.
Changes
modedefaulting toall.fromFileand deletion placeholders with the same default.kilo.mode: alltest so it also proves other Kilo-specific fields survive.kilo.mode: subagentopt-out in file-format docs and synced skill docs.kilocode.aitokilo.ai.Fixes #1634.
Verification
pnpm test src/features/subagents/kilo-subagent.test.tspnpm test:e2e src/e2e/e2e-subagents.spec.tspnpm cicheckReview notes
Opened as draft to signal ownership of the maintainer-scrap follow-up while keeping review pressure low. Local regression-gate review and PAL review were run; the only follow-up identified is a broader future cleanup to separate per-target subagent schemas from the shared OpenCode-style base constructor.