feat(codexcli): add PermissionRequest hook event - #1566
Merged
Conversation
Codex CLI v0.122.0 (2026-04-20) added the PermissionRequest hook event, fired before approval prompts. Register it in CODEXCLI_HOOK_EVENTS and canonical->Codex name map so rulesync can emit it in .codex/hooks.json. Closes dyoshikawa#1565
Owner
|
@saitota Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1565
Notes
statusMessage/decisionresponse fields are out of scope (passthrough via looseObject works).Tests
Added 3 unit tests in
codexcli-hooks.test.ts: forward conversion withBashmatcher, forward withapply_patch/ MCP matchers, and reverse conversion.Local verification
Verified with
rulesync convert --from claudecode --to codexcli --features hooks --globalagainst a real~/.claude/settings.json:PermissionRequesthooks emitted to~/.codex/hooks.jsoncorrectly.~/.codex/config.tomlgotcodex_hooks = trueadded without clobbering existing[mcp_servers].