Skip to content

fix: drop root frontmatter when building CopilotRule - #1563

Merged
dyoshikawa merged 1 commit into
mainfrom
codex/fix-issue-1545-in-rulesync
Apr 27, 2026
Merged

fix: drop root frontmatter when building CopilotRule#1563
dyoshikawa merged 1 commit into
mainfrom
codex/fix-issue-1545-in-rulesync

Conversation

@dyoshikawa

Copy link
Copy Markdown
Owner

Motivation

Description

  • Stop passing the computed copilotFrontmatter for root rules in CopilotRule.fromRulesyncRule() and explicitly pass frontmatter: {} for root conversions.
  • Keep non-root conversions unchanged and continue to populate copilotFrontmatter for non-root files.
  • Update unit tests in src/features/rules/copilot-rule.test.ts to assert root conversions return an empty frontmatter and no longer preserve description, globs, or copilot.excludeAgent via the root conversion path.
  • Minor test adjustments to reflect the new expected shapes for root rule roundtrips.

Testing

  • Ran the focused test file with pnpm vitest run src/features/rules/copilot-rule.test.ts and it passed (60/60 tests).
  • Ran full CI checks with pnpm cicheck, which includes formatting, linting, typecheck and the full test suite, and all automated checks passed (5260 tests passed, no failures).

Codex Task

@dyoshikawa
dyoshikawa merged commit 73d8900 into main Apr 27, 2026
10 checks passed
@dyoshikawa
dyoshikawa deleted the codex/fix-issue-1545-in-rulesync branch April 27, 2026 03:22
@dyoshikawa

Copy link
Copy Markdown
Owner Author

@dyoshikawa Thank you!

@github-actions github-actions Bot mentioned this pull request Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant