feat: add support for JetBrains Junie commands

[dacgray]

Implements the JunieCommand class and integrates it into the CommandsProcessor to enable command generation and import for JetBrains Junie. This allows rulesync to manage AI commands stored in the .junie/commands directory, supporting both project-level and global configurations with specific frontmatter handling.

[dacgray]

I've expanded test coverage.

/opencode other recommendations are out of scope for this PR.

[github-actions]

PR #1293 Review - JetBrains Junie Commands Support (Updated)

Overall Mergeability Verdict: CONDITIONALLY MERGEABLE

The original critical issue (test coverage significantly below standards) has been addressed. The test file expanded from ~120 lines to 352 lines with proper test utilities. One new HIGH severity finding exists, but the author has indicated additional work is out of scope for this PR.

---

Code Review Findings

1. HIGH: Missing global mode tests in junie-command.test.ts

   • JunieCommand is configured with supportsGlobal: true
   • No tests for fromRulesyncCommand or fromFile with global: true
   • Other commands in this PR (cline-command.test.ts, kilo-command.test.ts) include global mode tests
   • src/features/commands/junie-command.test.ts

2. MEDIUM: Missing validate() test for undefined frontmatter

   • Guard clause exists but isn't tested
   • src/features/commands/junie-command.ts:123-128

3. MEDIUM: Missing getSettablePaths test with global option

   • Should test both { global: true } and { global: false }
   • src/features/commands/junie-command.test.ts:146-151

4. LOW: Missing file not found error test

   • No test for fromFile error handling

5. LOW: Missing validate parameter tests

   • No tests for validate: false in fromRulesyncCommand and fromFile

---

Security Review Findings

6. MEDIUM: Path traversal - defense-in-depth issue

   • fromFile() doesn't validate relativeFilePath directly
   • Protected at caller level (CommandsProcessor, MCP) but lacks defense-in-depth
   • Applies to all ToolCommand subclasses, not just Junie
   • src/features/commands/junie-command.ts:156

7. LOW: Missing path traversal tests

   • No test cases for path traversal validation in JunieCommand

8. INFORMATIONAL: process.cwd() as default

   • Standard CLI practice - no issue

---

Positive Observations

✅ Test coverage significantly improved (352 lines vs ~120 original)
✅ Proper use of setupTestDirectory() and mocking
✅ Core functionality well tested (constructor, conversions, file loading)
✅ Field passthrough tests exist
✅ Implementation follows coding guidelines
✅ CommandsProcessor integration correct
✅ Strong Zod validation for frontmatter
✅ No command injection or secrets handling risks

---

Recommendations

• Address finding fix: Update pnpm version to 10.12.2 in CI and release workflows #1 (global mode tests) if time permits before merge
• Findings fix: add claudecode to valid targets in parser validation #2-5 can be addressed in follow-up PR
• Finding Add support for gemini-cli #6 (path traversal defense-in-depth) is a broader codebase issue, not specific to this PR

github run

github run

[dyoshikawa]

@dacgray Thank you!