ci: 共通アクションでコメント最小化を集約 - #1282
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: dyoshikawa <dyoshikawa@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
PR #1282 Review SummaryOverall Mergeability Verdict: Mergeable (No Medium/High/Critical Blockers)The PR successfully extracts reusable comment minimization logic into a composite action with good code quality and security practices. Code Review Findings
Security Review Findings
Summary
Recommendation: The PR is mergeable. Consider documenting the behavior change (issue #1) either in the PR description or as a follow-up. The low-severity issues are optional improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
変更内容
.github/actions/minimize-comments/action.ymltrigger_comment_node_idがある場合はトリガーコメントを最小化owner/repo/pr_number指定時はPRレビューコメントとIssueコメントの旧botコメントを最小化bot_loginsはカンマ区切りで上書き可能(デフォルトは現行互換).github/workflows/comment-to-ai.ymlhandle-issue/handle-pr-commentで新アクションを利用動作確認
yamllintは環境に存在せず未実施