fix(memcached): low cardinality span name (open-telemetry#1104)

dynatrace-oss-contrib · Aug 10, 2022 · cff4e77 · cff4e77
1 parent 4d62c92
commit cff4e77
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/plugins/node/opentelemetry-instrumentation-memcached/src/instrumentation.ts b/plugins/node/opentelemetry-instrumentation-memcached/src/instrumentation.ts
@@ -138,7 +138,7 @@ export class Instrumentation extends InstrumentationBase<typeof Memcached> {
       const query = original.apply(this, arguments as any);
       const callback = query.callback;
 
-      span.updateName(`${query.type} ${query.key}`);
+      span.updateName(`memcached ${query.type}`);
       span.setAttributes({
         'db.memcached.key': query.key,
         'db.memcached.lifetime': query.lifetime,

diff --git a/plugins/node/opentelemetry-instrumentation-memcached/test/index.test.ts b/plugins/node/opentelemetry-instrumentation-memcached/test/index.test.ts
@@ -280,7 +280,7 @@ const assertSpans = (actualSpans: any[], expectedSpans: any[]) => {
       assert.notStrictEqual(span, undefined);
       assert.notStrictEqual(expected, undefined);
       assertMatch(span.name, new RegExp(expected.op));
-      assertMatch(span.name, new RegExp(expected.key));
+      assertMatch(span.name, new RegExp('memcached'));
       assert.strictEqual(span.kind, SpanKind.CLIENT);
       assert.strictEqual(span.attributes['db.statement'], expected.statement);
       for (const attr in DEFAULT_ATTRIBUTES) {