Skip to content

Commit

Permalink
chore(mysql2): support version 3 (open-telemetry#1470)
Browse files Browse the repository at this point in the history
  • Loading branch information
haddasbronfman authored May 3, 2023
1 parent da737f1 commit 69d1f17
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions plugins/node/opentelemetry-instrumentation-mysql2/.tav.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
mysql2:
- versions: <4 >=3.2.0 || 3.1.0 || 3.0.0
commands: npm run test

- versions: <3 >=2.3.2 || 2.3.0 || 2.2.5 || 2.1.0
# Skip 2.3.3 which installs types from git which takes 10m on it's own
commands: npm run test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ npm install --save @opentelemetry/instrumentation-mysql2

## Supported Versions

- `>= 1.4.2, < 3.0`
- `>= 1.4.2, < 4.0`

## Usage

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export class MySQL2Instrumentation extends InstrumentationBase<any> {
return [
new InstrumentationNodeModuleDefinition<any>(
'mysql2',
['>= 1.4.2 < 3.0'],
['>= 1.4.2 < 4.0'],
(moduleExports: any, moduleVersion) => {
api.diag.debug(`Patching mysql@${moduleVersion}`);

Expand Down

0 comments on commit 69d1f17

Please sign in to comment.