fix(eslint-eqeqeq): updated the eqeqeq rule to match the core repo (o…

…pen-telemetry#1485) * fix(eslint-eqeqeq): updated eqeqeq from off to error * Revert "fix(eslint-eqeqeq): updated eqeqeq from off to error" This reverts commit b5ce8e58115d906b2f37c104521a1f31b4075c05. * fix(eslint-eqeqeq): removed unnecessary changes * Update plugins/node/opentelemetry-instrumentation-aws-lambda/src/instrumentation.ts Co-authored-by: Gerhard Stöbich <[email protected]> --------- Co-authored-by: Gerhard Stöbich <[email protected]> Co-authored-by: Haddas Bronfman <[email protected]>
dynatrace-oss-contrib · May 7, 2023 · 5709008 · 5709008
1 parent 7d31b69
commit 5709008
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 8 deletions.
diff --git a/eslint.config.js b/eslint.config.js
@@ -12,7 +12,10 @@ module.exports = {
   },
   rules: {
     "quotes": ["error", "single", { "avoidEscape": true }],
-    "eqeqeq": "off",
+    "eqeqeq": [
+      "error",
+      "smart"
+    ],
     "prefer-rest-params": "off",
     "no-shadow": "off",
     "node/no-deprecated-api": ["warn"],

diff --git a/plugins/node/opentelemetry-instrumentation-aws-lambda/src/instrumentation.ts b/plugins/node/opentelemetry-instrumentation-aws-lambda/src/instrumentation.ts
@@ -132,7 +132,7 @@ export class AwsLambdaInstrumentation extends InstrumentationBase {
               return moduleExports;
             },
             (moduleExports?: LambdaModule) => {
-              if (moduleExports == undefined) return;
+              if (moduleExports == null) return;
               diag.debug('Removing patch for lambda handler');
               this._unwrap(moduleExports, functionName);
             }

diff --git a/plugins/node/opentelemetry-instrumentation-aws-sdk/src/services/dynamodb.ts b/plugins/node/opentelemetry-instrumentation-aws-sdk/src/services/dynamodb.ts
@@ -41,7 +41,7 @@ export class DynamodbServiceExtension implements ServiceExtension {
       ),
     };
 
-    if (operation == 'BatchGetItem') {
+    if (operation === 'BatchGetItem') {
       spanAttributes[SemanticAttributes.AWS_DYNAMODB_TABLE_NAMES] = Object.keys(
         normalizedRequest.commandInput.RequestItems
       );

diff --git a/plugins/node/opentelemetry-instrumentation-graphql/test/graphql.test.ts b/plugins/node/opentelemetry-instrumentation-graphql/test/graphql.test.ts
@@ -1179,7 +1179,7 @@ describe('graphql', () => {
 
       it('should attach response hook data to the resulting spans', () => {
         const querySpan = spans.find(
-          span => span.attributes[AttributeNames.OPERATION_TYPE] == 'query'
+          span => span.attributes[AttributeNames.OPERATION_TYPE] === 'query'
         );
         const instrumentationResult = querySpan?.attributes[dataAttributeName];
         assert.deepStrictEqual(

diff --git a/plugins/node/opentelemetry-instrumentation-pino/src/instrumentation.ts b/plugins/node/opentelemetry-instrumentation-pino/src/instrumentation.ts
@@ -45,13 +45,13 @@ export class PinoInstrumentation extends InstrumentationBase {
           diag.debug(`Applying patch for pino@${moduleVersion}`);
           const instrumentation = this;
           const patchedPino = Object.assign((...args: unknown[]) => {
-            if (args.length == 0) {
+            if (args.length === 0) {
               return pinoModule({
                 mixin: instrumentation._getMixinFunction(),
               });
             }
 
-            if (args.length == 1) {
+            if (args.length === 1) {
               // eslint-disable-next-line @typescript-eslint/no-explicit-any
               const optsOrStream = args[0] as any;
               if (

diff --git a/propagators/opentelemetry-propagator-instana/src/InstanaPropagator.ts b/propagators/opentelemetry-propagator-instana/src/InstanaPropagator.ts
@@ -70,7 +70,7 @@ export class InstanaPropagator implements TextMapPropagator {
     setter.set(carrier, INSTANA_TRACE_ID_HEADER, spanContext.traceId);
     setter.set(carrier, INSTANA_SPAN_ID_HEADER, spanContext.spanId);
     const sampled =
-      (spanContext.traceFlags & TraceFlags.SAMPLED) == TraceFlags.SAMPLED;
+      (spanContext.traceFlags & TraceFlags.SAMPLED) === TraceFlags.SAMPLED;
     setter.set(carrier, INSTANA_LEVEL_HEADER, sampled ? '1' : '0');
   }
 

diff --git a/propagators/opentelemetry-propagator-ot-trace/src/OTTracePropagator.ts b/propagators/opentelemetry-propagator-ot-trace/src/OTTracePropagator.ts
@@ -87,7 +87,7 @@ export class OTTracePropagator implements TextMapPropagator {
 
   extract(context: Context, carrier: unknown, getter: TextMapGetter): Context {
     let traceId = readHeader(carrier, getter, OT_TRACE_ID_HEADER);
-    if (traceId.length == 16) traceId = `${PADDING}${traceId}`;
+    if (traceId.length === 16) traceId = `${PADDING}${traceId}`;
     const spanId = readHeader(carrier, getter, OT_SPAN_ID_HEADER);
     const sampled = readHeader(carrier, getter, OT_SAMPLED_HEADER);
     const traceFlags =