Skip to content

Commit

Permalink
test: fix redis-4 TAV tests with Node.js v14 (open-telemetry#1862)
Browse files Browse the repository at this point in the history
[email protected] was a bad release that accidentally broken v14 support.
This updates the versions test to skip that release, and also
reduces the number of versions tested from 27 to 8 by selecting
just the current latest minor releases.

Also, drop the pretest config that (a) was never used
because of the wrong indentation and (b) is no longer
valid since the move to npm workspaces.

Refs: open-telemetry#1860
  • Loading branch information
trentm authored Dec 14, 2023
1 parent 60328af commit 4f98916
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions plugins/node/opentelemetry-instrumentation-redis-4/.tav.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
redis:

jobs:
- versions: "^4.0.0"
# The latest minor releases in the range "^4.0.0", excluding
# "4.6.9", which was a bad release that accidentally broke
# node v14 support.
- versions: "4.0.0 || 4.0.6 || 4.1.1 || 4.2.0 || 4.3.1 || 4.4.0 || 4.5.1 || ^4.6.11"
commands: npm run test

# Fix missing `contrib-test-utils` package
pretest: npm run --prefix ../../../ lerna:link

0 comments on commit 4f98916

Please sign in to comment.