fix(eslint-config): replace gts with prettier and eslint (open-teleme…

…try#1439) * fix(eslint-config): replace gts with prettier and eslint recommended config * fix(eslint-config): using the core repo's configuration --------- Co-authored-by: Haddas Bronfman <[email protected]>
dynatrace-oss-contrib · May 1, 2023 · 2571c37 · 2571c37
1 parent 2d8e2b8
commit 2571c37
Show file tree

Hide file tree

Showing 59 changed files with 55 additions and 85 deletions.
diff --git a/archive/opentelemetry-browser-extension-autoinjection/package.json b/archive/opentelemetry-browser-extension-autoinjection/package.json
@@ -44,7 +44,6 @@
     "eslint-plugin-header": "3.1.1",
     "eslint-plugin-import": "2.25.4",
     "eslint-plugin-json5": "0.1.4",
-    "gts": "3.1.0",
     "html-webpack-plugin": "5.3.2",
     "jimp": "0.16.1",
     "jsdom": "15.2.1",

diff --git a/detectors/node/opentelemetry-resource-detector-alibaba-cloud/package.json b/detectors/node/opentelemetry-resource-detector-alibaba-cloud/package.json
@@ -47,7 +47,6 @@
     "@types/mocha": "8.2.3",
     "@types/node": "18.11.7",
     "@types/sinon": "10.0.2",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nock": "12.0.3",
     "nyc": "15.1.0",

diff --git a/detectors/node/opentelemetry-resource-detector-aws/package.json b/detectors/node/opentelemetry-resource-detector-aws/package.json
@@ -46,7 +46,6 @@
     "@types/mocha": "8.2.3",
     "@types/node": "18.11.7",
     "@types/sinon": "10.0.2",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nock": "12.0.3",
     "nyc": "15.1.0",

diff --git a/detectors/node/opentelemetry-resource-detector-container/package.json b/detectors/node/opentelemetry-resource-detector-container/package.json
@@ -41,7 +41,6 @@
     "@types/node": "^18.0.0",
     "@types/sinon": "10.0.2",
     "eslint-plugin-header": "^3.1.1",
-    "gts": "^3.1.0",
     "mocha": "7.2.0",
     "nock": "12.0.3",
     "nyc": "15.1.0",

diff --git a/detectors/node/opentelemetry-resource-detector-gcp/package.json b/detectors/node/opentelemetry-resource-detector-gcp/package.json
@@ -45,7 +45,7 @@
     "@opentelemetry/contrib-test-utils": "^0.33.2",
     "@types/mocha": "8.2.3",
     "@types/node": "18.11.7",
-    "gts": "3.1.0",
+    "@types/semver": "7.3.8",
     "mocha": "7.2.0",
     "nock": "12.0.3",
     "nyc": "15.1.0",

diff --git a/detectors/node/opentelemetry-resource-detector-github/package.json b/detectors/node/opentelemetry-resource-detector-github/package.json
@@ -49,7 +49,6 @@
     "@types/mocha": "8.2.3",
     "@types/node": "18.11.7",
     "@types/sinon": "10.0.2",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "rimraf": "4.2.0",

diff --git a/detectors/node/opentelemetry-resource-detector-instana/package.json b/detectors/node/opentelemetry-resource-detector-instana/package.json
@@ -47,7 +47,6 @@
     "@types/semver": "7.3.8",
     "mocha": "7.2.0",
     "nock": "12.0.3",
-    "gts": "3.1.0",
     "nyc": "15.1.0",
     "rimraf": "4.2.0",
     "ts-mocha": "10.0.0",

diff --git a/eslint.config.js b/eslint.config.js
@@ -2,50 +2,64 @@ module.exports = {
   plugins: [
     "@typescript-eslint",
     "header",
-    "import"
-  ],
-  extends: [
-      "./node_modules/gts",
+    "node",
+    "prettier"
   ],
+  extends: ["eslint:recommended", "plugin:@typescript-eslint/recommended", "plugin:prettier/recommended"],
   parser: "@typescript-eslint/parser",
   parserOptions: {
-      "project": "./tsconfig.json"
+    "project": "./tsconfig.json"
   },
   rules: {
-    "quotes": [2, "single", { "avoidEscape": true }],
-    "@typescript-eslint/no-this-alias": "off",
+    "quotes": ["error", "single", { "avoidEscape": true }],
     "eqeqeq": "off",
     "prefer-rest-params": "off",
-    "@typescript-eslint/naming-convention": [
-        "error",
-        {
-          "selector": "memberLike",
-          "modifiers": ["private", "protected"],
-          "format": ["camelCase"],
-          "leadingUnderscore": "require"
-        }
-    ],
-    "@typescript-eslint/no-inferrable-types": ["error", { ignoreProperties: true }],
-    "arrow-parens": ["error", "as-needed"],
-    "prettier/prettier": ["error", { "singleQuote": true, "arrowParens": "avoid" }],
+    "no-shadow": "off",
     "node/no-deprecated-api": ["warn"],
-    "header/header": [2, "block", [{
-        pattern: / \* Copyright The OpenTelemetry Authors[\r\n]+ \*[\r\n]+ \* Licensed under the Apache License, Version 2\.0 \(the \"License\"\);[\r\n]+ \* you may not use this file except in compliance with the License\.[\r\n]+ \* You may obtain a copy of the License at[\r\n]+ \*[\r\n]+ \*      https:\/\/www\.apache\.org\/licenses\/LICENSE-2\.0[\r\n]+ \*[\r\n]+ \* Unless required by applicable law or agreed to in writing, software[\r\n]+ \* distributed under the License is distributed on an \"AS IS\" BASIS,[\r\n]+ \* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied\.[\r\n]+ \* See the License for the specific language governing permissions and[\r\n]+ \* limitations under the License\./gm,
-        template:
+    "header/header": ["error", "block", [{
+      pattern: / \* Copyright The OpenTelemetry Authors[\r\n]+ \*[\r\n]+ \* Licensed under the Apache License, Version 2\.0 \(the \"License\"\);[\r\n]+ \* you may not use this file except in compliance with the License\.[\r\n]+ \* You may obtain a copy of the License at[\r\n]+ \*[\r\n]+ \*      https:\/\/www\.apache\.org\/licenses\/LICENSE-2\.0[\r\n]+ \*[\r\n]+ \* Unless required by applicable law or agreed to in writing, software[\r\n]+ \* distributed under the License is distributed on an \"AS IS\" BASIS,[\r\n]+ \* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied\.[\r\n]+ \* See the License for the specific language governing permissions and[\r\n]+ \* limitations under the License\./gm,
+      template:
         `\n * Copyright The OpenTelemetry Authors\n *\n * Licensed under the Apache License, Version 2.0 (the "License");\n * you may not use this file except in compliance with the License.\n * You may obtain a copy of the License at\n *\n *      https://www.apache.org/licenses/LICENSE-2.0\n *\n * Unless required by applicable law or agreed to in writing, software\n * distributed under the License is distributed on an "AS IS" BASIS,\n * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n * See the License for the specific language governing permissions and\n * limitations under the License.\n `
-    }]],
-    "import/no-extraneous-dependencies": ["error", { devDependencies: ["test/**/*.ts"] }],
+    }]]
   },
   overrides: [
     {
-      "files": ["test/**/*.ts"],
-      "rules": {
+      files: ['*.ts'],
+      rules: {
+        "@typescript-eslint/no-this-alias": "off",
+        "@typescript-eslint/naming-convention": [
+          "error",
+          {
+            "selector": "memberLike",
+            "modifiers": ["private", "protected"],
+            "format": ["camelCase"],
+            "leadingUnderscore": "require"
+          }
+        ],
+        "@typescript-eslint/no-var-requires": "off",
+        "@typescript-eslint/no-inferrable-types": ["error", { ignoreProperties: true }],
+        "@typescript-eslint/no-empty-function": ["off"],
+        "@typescript-eslint/ban-types": ["warn", {
+          "types": {
+            "Function": null,
+          }
+        }],
+        "@typescript-eslint/no-shadow": ["warn"],
+      }
+    },
+    {
+      files: ["test/**/*.ts"],
+      rules: {
         "no-empty": "off",
         "@typescript-eslint/ban-ts-ignore": "off",
         "@typescript-eslint/no-empty-function": "off",
         "@typescript-eslint/no-explicit-any": "off",
         "@typescript-eslint/no-unused-vars": "off",
-        "@typescript-eslint/no-var-requires": "off"
+        "@typescript-eslint/no-var-requires": "off",
+        "@typescript-eslint/no-shadow": ["off"],
+        "@typescript-eslint/no-floating-promises": ["off"],
+        "@typescript-eslint/no-non-null-assertion": ["off"],
+        "@typescript-eslint/explicit-module-boundary-types": ["off"]
       }
     }
   ]

diff --git a/metapackages/auto-instrumentations-node/package.json b/metapackages/auto-instrumentations-node/package.json
@@ -41,7 +41,6 @@
     "@types/mocha": "7.0.2",
     "@types/node": "18.11.7",
     "@types/sinon": "10.0.2",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "rimraf": "4.2.0",

diff --git a/metapackages/auto-instrumentations-web/package.json b/metapackages/auto-instrumentations-web/package.json
@@ -40,7 +40,6 @@
     "@types/sinon": "10.0.2",
     "@types/webpack-env": "1.16.2",
     "babel-loader": "8.2.2",
-    "gts": "3.1.0",
     "@jsdevtools/coverage-istanbul-loader": "3.0.5",
     "karma": "6.3.16",
     "karma-chrome-launcher": "^3.1.1",

diff --git a/package.json b/package.json
@@ -50,12 +50,15 @@
     "@typescript-eslint/parser": "5.8.1",
     "eslint": "8.7.0",
     "eslint-config-airbnb-base": "15.0.0",
+    "eslint-config-prettier": "8.8.0",
     "eslint-plugin-header": "3.1.1",
-    "eslint-plugin-import": "2.25.4",
-    "gts": "3.1.0",
+    "eslint-plugin-import": "2.27.5",
+    "eslint-plugin-node": "11.1.0",
+    "eslint-plugin-prettier": "4.2.1",
     "husky": "7.0.4",
     "lerna": "5.5.2",
     "lerna-changelog": "2.2.0",
+    "prettier": "2.8.7",
     "typescript": "4.4.4"
   },
   "changelog": {

diff --git a/packages/opentelemetry-host-metrics/package.json b/packages/opentelemetry-host-metrics/package.json
@@ -50,7 +50,6 @@
     "@types/mocha": "8.2.3",
     "@types/node": "18.11.7",
     "@types/sinon": "10.0.2",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "rimraf": "4.2.0",

diff --git a/packages/opentelemetry-id-generator-aws-xray/package.json b/packages/opentelemetry-id-generator-aws-xray/package.json
@@ -59,7 +59,6 @@
     "@types/node": "18.11.7",
     "@types/sinon": "10.0.2",
     "@types/webpack-env": "1.16.2",
-    "gts": "3.1.0",
     "@jsdevtools/coverage-istanbul-loader": "3.0.5",
     "karma": "6.3.16",
     "karma-chrome-launcher": "^3.1.1",

diff --git a/packages/opentelemetry-propagation-utils/package.json b/packages/opentelemetry-propagation-utils/package.json
@@ -50,7 +50,6 @@
     "@types/node": "18.11.7",
     "@types/sinon": "^10.0.11",
     "expect": "29.2.0",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "sinon": "15.0.1",

diff --git a/packages/opentelemetry-redis-common/package.json b/packages/opentelemetry-redis-common/package.json
@@ -41,7 +41,6 @@
   "devDependencies": {
     "@types/mocha": "^9.1.1",
     "@types/node": "18.11.7",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "ts-mocha": "10.0.0",

diff --git a/packages/opentelemetry-test-utils/package.json b/packages/opentelemetry-test-utils/package.json
@@ -43,7 +43,6 @@
   "devDependencies": {
     "@opentelemetry/api": "^1.3.0",
     "@types/node": "18.11.7",
-    "gts": "3.1.0",
     "typescript": "4.4.4"
   },
   "dependencies": {

diff --git a/plugins/node/instrumentation-amqplib/package.json b/plugins/node/instrumentation-amqplib/package.json
@@ -64,7 +64,6 @@
     "mocha": "7.2.0",
     "ts-mocha": "10.0.0",
     "nyc": "15.1.0",
-    "gts": "3.1.0",
     "sinon": "15.0.1",
     "test-all-versions": "5.0.1",
     "typescript": "4.4.4"

diff --git a/plugins/node/instrumentation-dataloader/package.json b/plugins/node/instrumentation-dataloader/package.json
@@ -53,7 +53,6 @@
     "@types/mocha": "7.0.2",
     "@types/node": "18.11.7",
     "dataloader": "2.2.1",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "rimraf": "4.2.0",

diff --git a/plugins/node/instrumentation-fs/package.json b/plugins/node/instrumentation-fs/package.json
@@ -50,7 +50,6 @@
     "@types/mocha": "7.0.2",
     "@types/node": "18.11.7",
     "@types/sinon": "^10.0.11",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "rimraf": "4.2.0",

diff --git a/plugins/node/instrumentation-lru-memoizer/package.json b/plugins/node/instrumentation-lru-memoizer/package.json
@@ -48,7 +48,6 @@
     "@types/mocha": "8.2.3",
     "@types/node": "18.11.7",
     "expect": "29.2.0",
-    "gts": "3.1.0",
     "lru-memoizer": "2.1.4",
     "mocha": "7.2.0",
     "nyc": "15.1.0",

diff --git a/plugins/node/instrumentation-mongoose/package.json b/plugins/node/instrumentation-mongoose/package.json
@@ -51,7 +51,6 @@
     "@types/mocha": "8.2.3",
     "@types/node": "18.11.7",
     "expect": "29.2.0",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "mongoose": "6.5.2",
     "nyc": "15.1.0",

diff --git a/plugins/node/instrumentation-socket.io/package.json b/plugins/node/instrumentation-socket.io/package.json
@@ -48,7 +48,6 @@
     "@types/mocha": "8.2.3",
     "@types/node": "18.11.7",
     "expect": "27.4.2",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "rimraf": "4.2.0",

diff --git a/plugins/node/instrumentation-tedious/package.json b/plugins/node/instrumentation-tedious/package.json
@@ -53,7 +53,6 @@
     "@opentelemetry/sdk-trace-base": "^1.8.0",
     "@types/mocha": "7.0.2",
     "@types/node": "18.11.7",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "rimraf": "4.2.0",

diff --git a/plugins/node/opentelemetry-instrumentation-aws-lambda/package.json b/plugins/node/opentelemetry-instrumentation-aws-lambda/package.json
@@ -52,7 +52,6 @@
     "@opentelemetry/sdk-metrics": "^1.8.0",
     "@types/mocha": "7.0.2",
     "@types/node": "18.11.7",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "rimraf": "4.2.0",

diff --git a/plugins/node/opentelemetry-instrumentation-aws-sdk/package.json b/plugins/node/opentelemetry-instrumentation-aws-sdk/package.json
@@ -67,7 +67,6 @@
     "aws-sdk": "2.1008.0",
     "eslint": "8.7.0",
     "expect": "29.2.0",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nock": "13.2.1",
     "nyc": "15.1.0",

diff --git a/plugins/node/opentelemetry-instrumentation-bunyan/package.json b/plugins/node/opentelemetry-instrumentation-bunyan/package.json
@@ -55,7 +55,6 @@
     "@types/node": "18.11.7",
     "@types/sinon": "10.0.2",
     "bunyan": "1.8.15",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "rimraf": "4.2.0",

diff --git a/plugins/node/opentelemetry-instrumentation-cassandra/package.json b/plugins/node/opentelemetry-instrumentation-cassandra/package.json
@@ -56,7 +56,6 @@
     "@types/semver": "7.3.8",
     "@types/sinon": "10.0.2",
     "cassandra-driver": "4.6.3",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "rimraf": "4.2.0",

diff --git a/plugins/node/opentelemetry-instrumentation-connect/package.json b/plugins/node/opentelemetry-instrumentation-connect/package.json
@@ -51,7 +51,6 @@
     "@types/mocha": "7.0.2",
     "@types/node": "18.11.7",
     "connect": "3.7.0",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "rimraf": "4.2.0",

diff --git a/plugins/node/opentelemetry-instrumentation-dns/package.json b/plugins/node/opentelemetry-instrumentation-dns/package.json
@@ -54,7 +54,6 @@
     "@types/semver": "7.3.8",
     "@types/shimmer": "1.0.2",
     "@types/sinon": "10.0.2",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "rimraf": "4.2.0",

diff --git a/plugins/node/opentelemetry-instrumentation-express/package.json b/plugins/node/opentelemetry-instrumentation-express/package.json
@@ -56,7 +56,6 @@
     "@types/node": "18.11.7",
     "@types/sinon": "10.0.9",
     "express": "4.17.3",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "rimraf": "4.2.0",

diff --git a/plugins/node/opentelemetry-instrumentation-fastify/package.json b/plugins/node/opentelemetry-instrumentation-fastify/package.json
@@ -55,7 +55,6 @@
     "@types/mocha": "7.0.2",
     "@types/node": "18.11.7",
     "fastify": "^4.5.3",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "rimraf": "4.2.0",

diff --git a/plugins/node/opentelemetry-instrumentation-generic-pool/package.json b/plugins/node/opentelemetry-instrumentation-generic-pool/package.json
@@ -53,7 +53,6 @@
     "@types/node": "18.11.7",
     "@types/semver": "7.3.8",
     "generic-pool": "3.8.2",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "rimraf": "4.2.0",

diff --git a/plugins/node/opentelemetry-instrumentation-graphql/package.json b/plugins/node/opentelemetry-instrumentation-graphql/package.json
@@ -53,7 +53,6 @@
     "@types/mocha": "8.2.3",
     "@types/node": "18.11.7",
     "graphql": "^16.5.0",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "rimraf": "4.2.0",

diff --git a/plugins/node/opentelemetry-instrumentation-hapi/package.json b/plugins/node/opentelemetry-instrumentation-hapi/package.json
@@ -52,7 +52,6 @@
     "@opentelemetry/sdk-trace-node": "^1.8.0",
     "@types/mocha": "7.0.2",
     "@types/node": "18.11.7",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "rimraf": "4.2.0",

diff --git a/plugins/node/opentelemetry-instrumentation-ioredis/package.json b/plugins/node/opentelemetry-instrumentation-ioredis/package.json
@@ -60,7 +60,6 @@
     "@types/node": "18.11.7",
     "cross-env": "7.0.3",
     "ioredis": "5.2.2",
-    "gts": "3.1.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",
     "rimraf": "4.2.0",

diff --git a/plugins/node/opentelemetry-instrumentation-knex/package.json b/plugins/node/opentelemetry-instrumentation-knex/package.json
@@ -51,7 +51,6 @@
     "@opentelemetry/sdk-trace-node": "^1.8.0",
     "@types/mocha": "7.0.2",
     "@types/node": "18.11.7",
-    "gts": "3.1.0",
     "knex": "0.95.9",
     "mocha": "7.2.0",
     "nyc": "15.1.0",

diff --git a/plugins/node/opentelemetry-instrumentation-koa/package.json b/plugins/node/opentelemetry-instrumentation-koa/package.json
@@ -57,7 +57,6 @@
     "@types/mocha": "7.0.2",
     "@types/node": "18.11.7",
     "@types/sinon": "10.0.9",
-    "gts": "3.1.0",
     "koa": "2.13.1",
     "mocha": "7.2.0",
     "nyc": "15.1.0",

diff --git a/plugins/node/opentelemetry-instrumentation-memcached/package.json b/plugins/node/opentelemetry-instrumentation-memcached/package.json
@@ -55,7 +55,6 @@
     "@types/mocha": "7.0.2",
     "@types/node": "18.11.7",
     "cross-env": "7.0.3",
-    "gts": "3.1.0",
     "memcached": "2.2.2",
     "mocha": "7.2.0",
     "nyc": "15.1.0",