Skip to content

Conversation

@yb6599
Copy link
Collaborator

@yb6599 yb6599 commented Oct 20, 2025

This PR separates DiscreteSINDy as a new class that derives from _BaseSINDy following the discussion in #351.
Also fixes #650.

@yb6599
Copy link
Collaborator Author

yb6599 commented Oct 20, 2025

The scikit-time tests fail as the scikit-time API has remained unchanged. How should I proceed with this? @Jacob-Stevens-Haas

@Jacob-Stevens-Haas
Copy link
Member

Jacob-Stevens-Haas commented Oct 20, 2025

Part of the problem with the face-to-face conversations is that I can't remember them.

Refresh my memory. What was the issue removing the parameter discrete_time from the scikit-time classes?

@yb6599
Copy link
Collaborator Author

yb6599 commented Oct 21, 2025

Removing discrete_time should not be a problem here. However, we had not decided how we would deal with the discrete time implementations of the scikit-time API.

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 96.10390% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.74%. Comparing base (472e5a2) to head (a8eeb56).

Files with missing lines Patch % Lines
pysindy/_core.py 95.97% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
- Coverage   95.03%   94.74%   -0.29%     
==========================================
  Files          38       38              
  Lines        4106     4148      +42     
==========================================
+ Hits         3902     3930      +28     
- Misses        204      218      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yb6599
Copy link
Collaborator Author

yb6599 commented Oct 21, 2025

Do we need _BaseSINDy.print() if we have SINDy.print() and DiscreteSINDy.print()?

Copy link
Member

@Jacob-Stevens-Haas Jacob-Stevens-Haas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

90% of the way there, thanks for this long work!

Few changes, few nits, few documentation/test things

@yb6599 yb6599 force-pushed the discrete-sindy-class branch from 0317cf6 to a8eeb56 Compare November 5, 2025 04:31
@yb6599
Copy link
Collaborator Author

yb6599 commented Nov 5, 2025

Ready for final review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Process Trajectories does not consider derivatives if provided.

3 participants