-
Notifications
You must be signed in to change notification settings - Fork 355
Separate DiscreteSINDy as a new class #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…atibility with multiple trajectories for DiscreteSINDy
|
The |
|
Part of the problem with the face-to-face conversations is that I can't remember them. Refresh my memory. What was the issue removing the parameter |
|
Removing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #654 +/- ##
==========================================
- Coverage 95.03% 94.74% -0.29%
==========================================
Files 38 38
Lines 4106 4148 +42
==========================================
+ Hits 3902 3930 +28
- Misses 204 218 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Do we need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
90% of the way there, thanks for this long work!
Few changes, few nits, few documentation/test things
0317cf6 to
a8eeb56
Compare
|
Ready for final review and merge. |
This PR separates
DiscreteSINDyas a new class that derives from_BaseSINDyfollowing the discussion in #351.Also fixes #650.