Merge pull request supabase#233 from supabase/chore/use_create_async_…

…runtime chore(s3): add not use existing create_async_runtime() comment
dymium-io · Feb 19, 2024 · 5b5c262 · 5b5c262
2 parents ee74f6e + c169e7e
commit 5b5c262
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/wrappers/src/fdw/s3_fdw/s3_fdw.rs b/wrappers/src/fdw/s3_fdw/s3_fdw.rs
@@ -113,6 +113,8 @@ impl S3Fdw {
 
 impl ForeignDataWrapper<S3FdwError> for S3Fdw {
     fn new(options: &HashMap<String, String>) -> S3FdwResult<Self> {
+        // cannot use create_async_runtime() as the runtime needs to be created
+        // for multiple threads
         let rt = tokio::runtime::Runtime::new()
             .map_err(CreateRuntimeError::FailedToCreateAsyncRuntime)?;
         let mut ret = S3Fdw {