-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eibc): auto create eibc demand order for rollapp packets #944
feat(eibc): auto create eibc demand order for rollapp packets #944
Conversation
…-modifable-demand-order
…ginal-recipient-and-not-from-fufliller-when-using-eibc' into mtsitrin/902-modifable-demand-order
…ginal-recipient-and-not-from-fufliller-when-using-eibc' into mtsitrin/902-modifable-demand-order
…auto-create-eibc-demand-order-for-rollapp-packets
…ginal-recipient-and-not-from-fufliller-when-using-eibc' into mtsitrin/902-modifable-demand-order
…auto-create-eibc-demand-order-for-rollapp-packets
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@@ -199,6 +139,66 @@ func (suite *KeeperTestSuite) TestMsgFulfillOrderWithoutEvents() { | |||
} | |||
} | |||
|
|||
func (suite *KeeperTestSuite) TestFulfillOrderEvent() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a 1 liner description
…auto-create-eibc-demand-order-for-rollapp-packets
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
========================================
Coverage 29.15% 29.16%
========================================
Files 243 247 +4
Lines 34148 34897 +749
========================================
+ Hits 9957 10178 +221
- Misses 22710 23211 +501
- Partials 1481 1508 +27 ☔ View full report in Codecov by Sentry. |
…or-rollapp-packets
… create eibc demand order for rollapp packets (#944)
This PR will auto create demand order with fee "0" for each incoming rollapp packet
Closes #919
partially #916