Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eibc): auto create eibc demand order for rollapp packets #944

Merged

Conversation

mtsitrin
Copy link
Contributor

This PR will auto create demand order with fee "0" for each incoming rollapp packet

Closes #919
partially #916

mtsitrin added 30 commits May 22, 2024 10:28
…ginal-recipient-and-not-from-fufliller-when-using-eibc' into mtsitrin/902-modifable-demand-order
@mtsitrin mtsitrin requested a review from a team as a code owner June 17, 2024 09:11
Copy link
Contributor

coderabbitai bot commented Jun 17, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mtsitrin mtsitrin requested review from omritoptix and danwt June 17, 2024 10:04
danwt
danwt previously approved these changes Jun 17, 2024
@@ -199,6 +139,66 @@ func (suite *KeeperTestSuite) TestMsgFulfillOrderWithoutEvents() {
}
}

func (suite *KeeperTestSuite) TestFulfillOrderEvent() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a 1 liner description

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 19.32203% with 476 lines in your changes missing coverage. Please review.

Project coverage is 29.16%. Comparing base (c3d9307) to head (8216602).
Report is 4 commits behind head on main.

Current head 8216602 differs from pull request most recent head 862b086

Please upload reports for the commit 862b086 to get more accurate results.

Files Patch % Lines
x/eibc/types/tx.pb.go 2.29% 381 Missing and 3 partials ⚠️
x/eibc/client/cli/tx.go 0.00% 37 Missing ⚠️
x/eibc/types/tx.go 51.21% 14 Missing and 6 partials ⚠️
x/eibc/keeper/msg_server.go 73.68% 10 Missing and 5 partials ⚠️
x/eibc/types/demand_order.go 42.30% 10 Missing and 5 partials ⚠️
x/eibc/types/params.go 0.00% 4 Missing ⚠️
x/eibc/keeper/handler.go 94.73% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main     #944    +/-   ##
========================================
  Coverage   29.15%   29.16%            
========================================
  Files         243      247     +4     
  Lines       34148    34897   +749     
========================================
+ Hits         9957    10178   +221     
- Misses      22710    23211   +501     
- Partials     1481     1508    +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from mtsitrin/902-modifable-demand-order to main June 18, 2024 11:13
@mtsitrin mtsitrin dismissed danwt’s stale review June 18, 2024 11:13

The base branch was changed.

@mtsitrin mtsitrin linked an issue Jun 18, 2024 that may be closed by this pull request
@mtsitrin mtsitrin merged commit 0274850 into main Jun 18, 2024
46 of 88 checks passed
@mtsitrin mtsitrin deleted the mtsitrin/919-auto-create-eibc-demand-order-for-rollapp-packets branch June 18, 2024 11:40
danwt added a commit that referenced this pull request Jun 18, 2024
… create eibc demand order for rollapp packets (#944)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto-create eibc demand order for rollapp packets
2 participants