refactor: add errorlint and make fmt.Errorf use %w to wrap error instead of %v #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwt
requested changes
May 13, 2024
cmd/dymd/cmd/inspect.go
Outdated
| @@ -69,7 +69,7 @@ func InspectCmd(appExporter types.AppExporter, appCreator types.AppCreator, defa | |||
| height, _ := cmd.Flags().GetInt64(FlagHeight) | |||
| exported, err := appExporter(serverCtx.Logger, db, traceWriter, height, false, []string{}, serverCtx.Viper) | |||
| if err != nil { | |||
| return fmt.Errorf("error exporting state: %v", err) | |||
| return fmt.Errorf("error exporting state: %w", err) | |||
cmd/dymd/cmd/inspect.go
Outdated
| @@ -116,7 +116,7 @@ func InspectCmd(appExporter types.AppExporter, appCreator types.AppCreator, defa | |||
| dataDir := filepath.Join(config.RootDir, "data") | |||
| directories, err := os.ReadDir(dataDir) | |||
| if err != nil { | |||
| return fmt.Errorf("Error reading directory: %v", err) | |||
| return fmt.Errorf("error reading directory: %w", err) | |||
danwt
requested changes
May 13, 2024
cmd/dymd/cmd/inspect.go
Outdated
| @@ -69,7 +69,7 @@ func InspectCmd(appExporter types.AppExporter, appCreator types.AppCreator, defa | |||
| height, _ := cmd.Flags().GetInt64(FlagHeight) | |||
| exported, err := appExporter(serverCtx.Logger, db, traceWriter, height, false, []string{}, serverCtx.Viper) | |||
| if err != nil { | |||
| return fmt.Errorf("error exporting state: %v", err) | |||
| return fmt.Errorf("error exporting state: %w", err) | |||
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("error exporting state: %w", err) | |
| return fmt.Errorf("exporting state: %w", err) |
cmd/dymd/cmd/inspect.go
Outdated
| @@ -116,7 +116,7 @@ func InspectCmd(appExporter types.AppExporter, appCreator types.AppCreator, defa | |||
| dataDir := filepath.Join(config.RootDir, "data") | |||
| directories, err := os.ReadDir(dataDir) | |||
| if err != nil { | |||
| return fmt.Errorf("Error reading directory: %v", err) | |||
| return fmt.Errorf("error reading directory: %w", err) | |||
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("error reading directory: %w", err) | |
| return fmt.Errorf("reading directory: %w", err) |
|
Thank @danwt for feedback, i updated |
|
thanks @hoank101. can you please resolve conflicts? |
… hoa/refactor-error # Conflicts: # .golangci.yml
yeah, resolved |
|
@hoank101 you should re-request review if you want review again |
mtsitrin
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #XXX
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdgodoccommentsSDK Checklist
maptime.Now()sendCoinand notSendCoinsFull security checklist here
----;
For Reviewer:
---;
After reviewer approval: